Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Open chat when executing agent node in canvas v2 #12617

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(editor): Open chat when executing agent node in canvas v2 #12617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc8aaab
fix(editor): Open chat when executing agent node in canvas v2
tomi Jan 15, 2025
4932f56
test: Clear notifications after saving credentials in e2e tests
tomi Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cypress/composables/modals/credential-modal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
* Getters
*/

import { clearNotifications } from '../../pages/notifications';

export function getCredentialConnectionParameterInputs() {
return cy.getByTestId('credential-connection-parameter');
}
Expand Down Expand Up @@ -55,5 +57,6 @@ export function setCredentialValues(values: Record<string, string>, save = true)
if (save) {
saveCredential();
closeCredentialModal();
clearNotifications();
}
}
2 changes: 2 additions & 0 deletions packages/editor-ui/src/views/NodeView.v2.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,11 +924,13 @@ async function onImportWorkflowUrlEvent(data: IDataObject) {
function addImportEventBindings() {
nodeViewEventBus.on('importWorkflowData', onImportWorkflowDataEvent);
nodeViewEventBus.on('importWorkflowUrl', onImportWorkflowUrlEvent);
nodeViewEventBus.on('openChat', onOpenChat);
}

function removeImportEventBindings() {
nodeViewEventBus.off('importWorkflowData', onImportWorkflowDataEvent);
nodeViewEventBus.off('importWorkflowUrl', onImportWorkflowUrlEvent);
nodeViewEventBus.off('openChat', onOpenChat);
}

/**
Expand Down
Loading