-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Fix method param type expansion for partial annotation coverage #3424
BUGFIX: Fix method param type expansion for partial annotation coverage #3424
Conversation
Adjusts the behavior of `ReflectionService::getMethodParameters()` such that `@param` annotations are mapped to the corresponding method argument based in their _name_ instead of the _index_. Fixes: #3423
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! Works as expected in my test cases :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
StyleCI is complaining about ... style. |
Neos.Flow/Tests/Functional/Reflection/ReflectionServiceTest.php
Outdated
Show resolved
Hide resolved
Neos.Flow/Tests/Functional/Reflection/ReflectionServiceTest.php
Outdated
Show resolved
Hide resolved
FYI: This changes behavior when used with union parameters in type hints that contain spaces ... before:
@see: https://github.com/neos/neos-development-collection/blob/796fe8f3eb6cdfbed7a75833725587bcaa59ce66/Neos.Media/Classes/Domain/Model/Adjustment/CropImageAdjustment.php#L162C4-L168C3 |
The related neos bug: neos/neos-development-collection#5448 |
Adjusts the behavior of
ReflectionService::getMethodParameters()
such that@param
annotations are mapped to the corresponding method argument based in their name instead of the index.Fixes: #3423