FEATURE: cr:list command
#4900
FEATURE: cr:list command
#4900
Conversation
mhsdesign
force-pushed
the
feature/crListCommand
branch
from
26fff3a to
4cb1889
Compare
| @@ -33,6 +33,11 @@ class ContentStreamCommandController extends CommandController | |||
| */ | |||
| public function pruneCommand(string $contentRepository = 'default', bool $removeTemporary = false): void | |||
| { | |||
| if (!$this->output->askConfirmation(sprintf('> This operation in "%s" cannot be reverted. Are you sure to proceed? (y/n) ', $contentRepository), false)) { | |||
There was a problem hiding this comment.
@mhsdesign What was the intention on adding this unskippable confirmation? I remember using the pruneCommand and pruneRemovedFromEventStreamCommand regularly to cleanup the database.
There was a problem hiding this comment.
its a safety measurement we already have in place in other locations but forgot about this one ... like cr:prune and cr:projectionReplay etc
There was a problem hiding this comment.
Hm. But do we really assume that this commands will only ever have the need to be triggered manually? Cleaning up the contentstream tables of junk data is a bit of a different use case then cr:prune and cr:projectionReplay.
And I'm worried about adding this change now in a feature PR without addressing it. This might be a change someone running an active Neos 9 project would like to see in the Logs.
There was a problem hiding this comment.
Imho this must be able to be part of a deployment process, so at least a confirmation parameter must be added to the CLI call.
|
future idea from christian: show also if there is a mismatch between actual dimensions and configured ones ... that will make this clearly a |
advanced / verbose output (using internal stuff)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions