BUGFIX: DateTime node property with defaultValue
#4902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
changed the title
DateTime node property inconsistenciesDateTime node property with defaultValue
bwaidelich
reviewed
Feb 23, 2024
Neos.ContentRepository.Core/Classes/Infrastructure/Property/PropertyConverter.php
Show resolved
Hide resolved
no this fixes EVERYTHING. |
kitsunet
approved these changes
Feb 29, 2024
the property should be a `DateTimeImmutable` and thus NOT mutable - Add test for that `type: DateTime` is now a `DateTimeImmutable`
That will lead to relative `DateTime` values like `now` reflecting the actual time when the command was handled, rather glitching around and reflecting the date when being fetched.
…CreateNodeAggregateWithNode` This is now part of the inner `handleCreateNodeAggregateWithNodeAndSerializedProperties` via `SerializedPropertyValues::defaultFromNodeType`
With neos#4251 `NodeType::getDefaultValuesForProperties` doesnt return a `DateTime` anymore for dateTime default values
mhsdesign
force-pushed
the
bugfix/dateTimeNodePropertyInconsistencies
branch
from
b9b843b to
41bc886
Compare
mhsdesign
force-pushed
the
bugfix/dateTimeNodePropertyInconsistencies
branch
from
ede965b to
3117ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4901
Upgrade instructions
In case you already used
defaultValuewith a relative string likenow, you have to manually migrate the events by hand.Not doing so is not critical as the node property will still work, just a little unexpected as
nowwill always be now.If there is much demand for it, we can provide an optional migration to handle
DateTimeininitialPropertiescorrectly.But it is to be suspected that this feature was not yet used as its a niche thing.
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions