Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Upgrade to FontAwesome 6.5.2 #5108

Merged
merged 1 commit into from
Jun 5, 2024
Merged

TASK: Upgrade to FontAwesome 6.5.2 #5108

merged 1 commit into from
Jun 5, 2024

Conversation

wiegandj
Copy link
Collaborator

@wiegandj wiegandj commented Jun 1, 2024 •
edited
Loading

Issue: #5107

Upgraded FontAwesome in neos-development-collection to 6.5.2.

Briefly tested locally and it was functioning fine. Oriented on the last upgrade branch for 5.8.2.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@wiegandj wiegandj mentioned this pull request Jun 1, 2024
Closed
1 task
@mhsdesign mhsdesign changed the base branch from 8.3 to 8.4 June 2, 2024 19:59
@github-actions github-actions bot added 8.4 and removed 8.3 labels Jun 2, 2024
@ahaeslich ahaeslich changed the base branch from 8.4-broken to 8.4 June 4, 2024 16:57
@github-actions github-actions bot added the 8.3 label Jun 4, 2024
@ahaeslich ahaeslich removed the 8.3 label Jun 5, 2024
@Sebobo Sebobo force-pushed the upgrade-fontawesome-to-6-5-2 branch from fbe60a6 to a58d021 Compare June 5, 2024 10:02
Sebobo
Sebobo approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change didn't work for me until I updated the Font variables in den _Constants.scss and rebuilt.
But now it works and I pushed my changes.

Thx for your contribution!

@ahaeslich ahaeslich linked an issue Jun 5, 2024 that may be closed by this pull request
FEATURE: upgrade FontAwesome to latest version (6.5.2) #5107
Closed
1 task
@ahaeslich ahaeslich merged commit 8bf3fce into neos:8.4 Jun 5, 2024
8 checks passed
@ahaeslich ahaeslich mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahaeslich ahaeslich ahaeslich approved these changes

@Sebobo Sebobo Sebobo approved these changes

@dr-format-d dr-format-d Awaiting requested review from dr-format-d

@markusguenther markusguenther Awaiting requested review from markusguenther

Assignees
No one assigned
Labels
8.4 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: upgrade FontAwesome to latest version (6.5.2)
3 participants
@wiegandj @Sebobo @ahaeslich