-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Dont initialize $currentContentStreamId by default in behat tests #5162
Merged
mhsdesign
merged 3 commits into
neos:9.0
from
mhsdesign:bugfix/dont-initialize-current-content-stream-id-by-default-in-tests
Jun 27, 2024
Merged
BUGFIX: Dont initialize $currentContentStreamId by default in behat tests #5162
mhsdesign
merged 3 commits into
neos:9.0
from
mhsdesign:bugfix/dont-initialize-current-content-stream-id-by-default-in-tests
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
bugfix/dont-initialize-current-content-stream-id-by-default-in-tests
branch
from
June 23, 2024 18:07
5f94351
to
78e0f89
Compare
mhsdesign
force-pushed
the
bugfix/dont-initialize-current-content-stream-id-by-default-in-tests
branch
from
June 24, 2024 06:53
78e0f89
to
0f199f3
Compare
grebaldi
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 by 👀
pKallert
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 I did not check all occurences (but most of them) but I guess it also will not break any tests where it is currently used 🙂
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jun 28, 2024
mhsdesign
deleted the
bugfix/dont-initialize-current-content-stream-id-by-default-in-tests
branch
June 28, 2024 20:09
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jun 29, 2024
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jul 1, 2024
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #5034
With #5040
the step
I am in the active content stream of workspace "live"
was turned intoI am in workspace "live"
.That is problematic as the step
now hardcodes the
$currentContentStreamId
making assertions after changing the workspaces content stream (publish or discard) seem at first broken.A current workaround is to repeat the step after discarding for example:
... but all test pass after these adjustments so id say we dont need the hack in the first place.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions