Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Dont initialize $currentContentStreamId by default in behat tests #5162

Merged
merged 3 commits into from
Jun 27, 2024
Merged

BUGFIX: Dont initialize $currentContentStreamId by default in behat tests #5162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea28204
BUGFIX: Dont initialize $currentContentStreamId by default in behat t…
mhsdesign Jun 23, 2024
39c80b0
TASK: Remove duplicated `And I am in workspace` declarations
mhsdesign Jun 23, 2024
0f199f3
TASK: Cleanup for #5163 remove now obsolete step
mhsdesign Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...tRepository.TestSuite/Classes/Behavior/Features/Bootstrap/CRTestSuiteRuntimeVariables.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,8 @@ public function iAmInContentStream(string $contentStreamId): void
*/
public function iAmInWorkspace(string $workspaceName): void
{
$workspace = $this->currentContentRepository->getWorkspaceFinder()->findOneByName(WorkspaceName::fromString($workspaceName));
if ($workspace === null) {
throw new \Exception(sprintf('Workspace "%s" does not exist, projection not yet up to date?', $workspaceName), 1548149355);
}
$this->currentWorkspaceName = WorkspaceName::fromString($workspaceName);
$this->currentContentStreamId = $workspace->currentContentStreamId;
$this->currentContentStreamId = null;
}

/**
Expand Down
3 changes: 0 additions & 3 deletions Neos.Neos/Tests/Behavior/Features/ContentCache/NodesInUserWorkspace.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ Feature: Tests for the ContentCacheFlusher and cache flushing when applied in us
When the command DiscardWorkspace is executed with payload:
| Key | Value |
| workspaceName | "user-editor" |
# FIXME we have to reevaluated the step as we cache the $currentContentStreamId and it will be outdated after the discard
# see https://github.com/neos/neos-development-collection/pull/5162
And I am in workspace "user-editor" and dimension space point {}
Then I expect node aggregate identifier "text-node-middle" to lead to no node

When I execute the following Fusion code:
Expand Down
1 change: 0 additions & 1 deletion Neos.Neos/Tests/Behavior/Features/FrontendRouting/Basic.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ Feature: Basic routing functionality (match & resolve document nodes in one dime
# earl-o-documentbourgh
# nody-mc-nodeface
#
And I am in workspace "live" and dimension space point {}
And the following CreateNodeAggregateWithNode commands are executed:
| nodeAggregateId | parentNodeAggregateId | nodeTypeName | initialPropertyValues | nodeName |
| shernode-homes | lady-eleonode-rootford | Neos.Neos:Test.Routing.Page | {"uriPathSegment": "ignore-me"} | node1 |
Expand Down
2 changes: 0 additions & 2 deletions Neos.Neos/Tests/Behavior/Features/FrontendRouting/Lowlevel_ProjectionTests.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ Feature: Low level tests covering the inner behavior of the routing projection
| "c" | "lady-eleonode-rootford/shernode-homes/c" | "c" | "shernode-homes" | "b" | null | "Neos.Neos:Test.Routing.Page" |

Scenario: ab(> b1, b2 > b2a)c => a(> b2 > b2a)b(> b1)c (moving b1 below a)
And I am in workspace "live" and dimension space point {}
And the following CreateNodeAggregateWithNode commands are executed:
| nodeAggregateId | parentNodeAggregateId | nodeTypeName | initialPropertyValues | nodeName |
| b1 | b | Neos.Neos:Test.Routing.Page | {"uriPathSegment": "b1"} | b1 |
Expand All @@ -246,7 +245,6 @@ Feature: Low level tests covering the inner behavior of the routing projection
| "c" | "lady-eleonode-rootford/shernode-homes/c" | "c" | "shernode-homes" | "b" | null | "Neos.Neos:Test.Routing.Page" |

Scenario: ab(> b1, b2 > b2a)c => b(> b1, a, b2 > b2a)c (moving a below b)
And I am in workspace "live" and dimension space point {}
And the following CreateNodeAggregateWithNode commands are executed:
| nodeAggregateId | parentNodeAggregateId | nodeTypeName | initialPropertyValues | nodeName |
| b1 | b | Neos.Neos:Test.Routing.Page | {"uriPathSegment": "b1"} | b1 |
Expand Down
1 change: 0 additions & 1 deletion Neos.Neos/Tests/Behavior/Features/FrontendRouting/RouteCache.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ Feature: Route cache invalidation
# earl-o-documentbourgh
# nody-mc-nodeface
#
And I am in workspace "live" and dimension space point {}
And the following CreateNodeAggregateWithNode commands are executed:
| nodeAggregateId | parentNodeAggregateId | nodeTypeName | initialPropertyValues | nodeName |
| shernode-homes | lady-eleonode-rootford | Neos.Neos:Test.Routing.Page | {"uriPathSegment": "ignore-me"} | node1 |
Expand Down
Loading