Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update learnmsa #7413

Merged
merged 10 commits into from
Jan 31, 2025
Merged

Update learnmsa #7413

merged 10 commits into from
Jan 31, 2025

Conversation

luisas
Copy link
Contributor

@luisas luisas commented Jan 31, 2025

Fix LEARNMSA align module.

The previous container was not the complete one. This caused the tool to crash given certain optional flags (e.g. --use_language_model). Now it is the official one.

It cannot be done in seqera containers because of Gaius-Augustus/learnMSA#18

Since the original container is 13GB - the tests are run in stub and in a smaller container.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small comments, otherwise LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file name should end with .yml, not .yaml, for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh upsi yes! thanksss


input:
tuple val(meta), path(fasta)
val(compress)

output:
tuple val(meta), path("*.aln{.gz,}"), emit: alignment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am I understanding well that the output will never be compressed now?

Suggested change
tuple val(meta), path("*.aln{.gz,}"), emit: alignment
tuple val(meta), path("*.aln"), emit: alignment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this, the meta.yml will have to change too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ups yes, i forgot to update the meta! I just removed the compressed flag

Yes now i moved the compression outside - so i have a module in the MSA pipeline doing the compression for learnmsa :)

@luisas luisas enabled auto-merge January 31, 2025 16:08
@luisas luisas added this pull request to the merge queue Jan 31, 2025
Merged via the queue into nf-core:master with commit ad84529 Jan 31, 2025
18 checks passed
@luisas luisas deleted the update_learnmsa branch January 31, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants