-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update learnmsa #7413
Update learnmsa #7413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small comments, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file name should end with .yml
, not .yaml
, for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh upsi yes! thanksss
|
||
input: | ||
tuple val(meta), path(fasta) | ||
val(compress) | ||
|
||
output: | ||
tuple val(meta), path("*.aln{.gz,}"), emit: alignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am I understanding well that the output will never be compressed now?
tuple val(meta), path("*.aln{.gz,}"), emit: alignment | |
tuple val(meta), path("*.aln"), emit: alignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change this, the meta.yml
will have to change too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ups yes, i forgot to update the meta! I just removed the compressed flag
Yes now i moved the compression outside - so i have a module in the MSA pipeline doing the compression for learnmsa :)
Fix LEARNMSA align module.
The previous container was not the complete one. This caused the tool to crash given certain optional flags (e.g. --use_language_model). Now it is the official one.
It cannot be done in seqera containers because of Gaius-Augustus/learnMSA#18
Since the original container is 13GB - the tests are run in stub and in a smaller container.
PR checklist
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda