detect-hostname-change: improve installer detection #601
Conversation
|
The disko installTest uses |
| # Ignore if the system is getting installed | ||
| if [[ ! -e /run/current-system ]]; then | ||
| # https://github.com/nix-community/nixos-images/blob/2fc023e024c0a5e8e98ae94363dbf2962da10886/nix/installer.nix#L12-L13 | ||
| if [[ ! -e /run/current-system || "$actual" == "nixos" || "$actual" == "nixos-installer" ]]; then |
There was a problem hiding this comment.
By default the NixOS installer ISOs use nixos as the hostname
There was a problem hiding this comment.
That's not specific to the installer, but just the default for networking.hostName if unset.
So if your goal here is to check for installers, it's probably preferable to check /etc/os-release for VARIANT_ID as nixos-anywhere does. Or an other method which isn't as likely to yield false matches.
If it's even needed, the check is easy to disable during install via NIXOS_NO_CHECK
I proposed that for nixos-anywhere in nix-community/nixos-anywhere#447
There was a problem hiding this comment.
We can't check /etc/os-release because this runs as part of activation which runs inside the nixos-enter chroot
Instead after some testing I realized that /run/booted-system won't exist when installing as it gets created by stage 2 normally
I've also removed the nixos hostname check
Enzime
force-pushed
the
improve-installer-detection
branch
2 times, most recently
from
8141ef1 to
291a502
Compare
Enzime
force-pushed
the
improve-installer-detection
branch
from
291a502 to
3351e1b
Compare
Currently the detection fails if we're trying to do an installation from a NixOS system or installer, the only time I can see that check working is if someone was trying to run
nixos-installdirectly from a non-NixOS Linux distro which would also require they have Nix installed which would be super uncommon