feat: add correct-ts-specifiers

[JakobJingleheimer]

Depends on #6

[AugustinMauroy]

Okay frist review. mostly code style

[AugustinMauroy]

Suggested change

	import assert from 'node:assert/strict';
	import { type Mock, afterEach, before, describe, it, mock } from 'node:test';
	import { fileURLToPath } from 'node:url';
	import assert from 'node:assert/strict';
	import { afterEach, before, describe, it, mock } from 'node:test';
	import { fileURLToPath } from 'node:url';
	import type { Mock } from 'node:test'

I recommend separating js import and type import

[JakobJingleheimer]

Not opposed, but why?

[AugustinMauroy]

but why?

So it's a bit stupid, but on the one hand you have an import of code (js) that will be executed and on the other hand the typing (ts/d.ts) that will be removed by the transpiler.

[JakobJingleheimer]

Hmm, I think combining them is better because it's easier to grok and realise A and type B are coming from the same place. Also, separating them rather significantly increases size.

[AugustinMauroy]

That's true. I think they're both equally good. We'll have to see what the rest of the team thinks.

[AugustinMauroy]

Suggested change

	import assert from 'node:assert/strict';
	import path from 'node:path';
	import { type Mock, after, afterEach, before, describe, it, mock } from 'node:test';
	import { fileURLToPath } from 'node:url';
	import assert from 'node:assert/strict';
	import path from 'node:path';
	import { after, afterEach, before, describe, it, mock } from 'node:test';
	import { fileURLToPath } from 'node:url';
	import type { Mock } from 'node:test';

[AugustinMauroy]

Suggested change

	import type { FSAbsolutePath, NodeModSpecifier, ResolvedSpecifier, Specifier } from './index.d.ts';
	import { type DExt, type JSExt, type TSExt, extSets, suspectExts } from './exts.ts';
	import { fexists } from './fexists.ts';
	import { logger } from './logger.ts';
	import { isDir } from './is-dir.ts';
	import type { FSAbsolutePath, NodeModSpecifier, ResolvedSpecifier, Specifier } from './index.d.ts';
	import type { DExt, JSExt, TSExt } from './exts.ts';
	import { extSets, suspectExts } from './exts.ts';
	import { fexists } from './fexists.ts';
	import { logger } from './logger.ts';
	import { isDir } from './is-dir.ts';

[AugustinMauroy]

Suggested change

	import { type Api, api } from '@codemod.com/workflow';
	import { api } from '@codemod.com/workflow';
	import type { Api } from '@codemod.com/workflow';

Copilot reviewed 76 out of 79 changed files in this pull request and generated no suggestions.

Files not reviewed (3)

• recipes/correct-ts-specifiers/package.json: Language not supported
• recipes/correct-ts-specifiers/src/fixtures/ambiguous.ts: Evaluated as low risk
• recipes/correct-ts-specifiers/src/fixtures/bar.js: Evaluated as low risk

Comments skipped due to low confidence (1)

recipes/correct-ts-specifiers/src/fexists.test.ts:120

• [nitpick] The test description is duplicated. Consider renaming it to 'should return false for a relative specifier with query parameter'.

it('should return `false` for a relative specifier', async () => {

[AugustinMauroy]

you can just import register because it's the only api we use on this file

Suggested change

	module.register('@nodejs-loaders/alias', import.meta.url);
	register('@nodejs-loaders/alias', import.meta.url);

[JakobJingleheimer]

I thought of that. I went with module.register to make it more clear what is happening (lots of APIs have register).

Is there a perf improvement to this or is it just 4 characters fewer?

[AugustinMauroy]

Is there a perf improvement to this or is it just 4 characters fewer?

normally importing whole api isn't a issue, except when it's a big JS module

[JakobJingleheimer]

I don't feel strongly, maybe 6/10. If you feel stronger, we can go with that. Otherwise, meh, let's just leave it.

[AugustinMauroy]

I think we can leave it like that. And yes, I ask a lot of questions, but this is the first codemod we've done, so we have to lay the foundations.

[AugustinMauroy]

maybe use styleText to have something coooollll

[JakobJingleheimer]

MVP first 😜 been working on this thing since like June

[AugustinMauroy]

Oh yeah, holly molly macaroni