Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] chart panel: wrongly aligned ColorPicker #2807

Closed
wants to merge 1 commit into from
Closed

[FIX] chart panel: wrongly aligned ColorPicker #2807

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

Since a component ColorPickerWidget was created, the color picker icon was misaligned with its text in the chart side panels. Fix this issue.

Task:

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : 3380585

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[FIX] chart panel: wrongly aligned ColorPicker
fc32441 
Since a component ColorPickerWidget was created, the color picker icon was
misaligned with its text in the chart side panels. Fix this issue.

Task: 3380585
@robodoo
Copy link
Collaborator

robodoo commented Aug 17, 2023

Pull request status dashboard.

@rrahir
Copy link
Collaborator

rrahir commented Aug 17, 2023

@fw-bot up-to saas-16.4

@hokolomopo
Copy link
Contributor Author

@fw-bot

@hokolomopo hokolomopo closed this Aug 17, 2023
@hokolomopo hokolomopo reopened this Aug 17, 2023
@rrahir
Copy link
Collaborator

rrahir commented Aug 18, 2023

@fw-bot up to saas-16.4

@rrahir
Copy link
Collaborator

rrahir commented Aug 18, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 18, 2023
@hokolomopo
[FIX] chart panel: wrongly aligned ColorPicker
88c53ba 
Since a component ColorPickerWidget was created, the color picker icon was
misaligned with its text in the chart side panels. Fix this issue.

closes #2807

Task: 3380585
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@fw-bot
Copy link
Collaborator

fw-bot commented Aug 18, 2023

Forward-porting to 'saas-16.4'.

@robodoo robodoo temporarily deployed to merge August 18, 2023 06:26 Inactive
@robodoo robodoo closed this Aug 18, 2023
@fw-bot fw-bot mentioned this pull request Aug 18, 2023
Closed
14 tasks
@fw-bot fw-bot deleted the saas-16.3-fix-colorpicker-widget-position-adrm branch September 1, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hokolomopo @robodoo @rrahir @fw-bot