-
Notifications
You must be signed in to change notification settings - Fork 26.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Move SUPERUSER_ID to odoo.api #182371
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac0fdd1
to
b1c05ce
Compare
kmagusiak
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Oct 1, 2024
kmagusiak
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Jan 24, 2025
be09a3a
to
50ed925
Compare
@rco-odoo @Julien00859 rebased and removed the necessity to do a mass update (kept some changes in base). |
rco-odoo
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only remark is about a comment 😉
@robodoo delegate+ |
50ed925
to
1f452f7
Compare
In order to become a native namespace, `odoo` package must not contain any variables. This is a step in that direction. `odoo.SUPERUSER_ID` still continues to work. odoo.api.SUPERUSER_ID is often used with Environment, so we declare both in the same package. task-4069446
1f452f7
to
fd08d4b
Compare
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 28, 2025
In order to become a native namespace, `odoo` package must not contain any variables. This is a step in that direction. `odoo.SUPERUSER_ID` still continues to work. odoo.api.SUPERUSER_ID is often used with Environment, so we declare both in the same package. task-4069446 closes #182371 Related: odoo/upgrade-util#144 Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
robodoo
pushed a commit
to odoo/upgrade-util
that referenced
this pull request
Jan 28, 2025
odoo/odoo#182371 closes #144 Signed-off-by: Christophe Simonis (chs) <[email protected]>
julien-banken
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 28, 2025
In order to become a native namespace, `odoo` package must not contain any variables. This is a step in that direction. `odoo.SUPERUSER_ID` still continues to work. odoo.api.SUPERUSER_ID is often used with Environment, so we declare both in the same package. task-4069446 closes odoo#182371 Related: odoo/upgrade-util#144 Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
Deimort
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 30, 2025
In order to become a native namespace, `odoo` package must not contain any variables. This is a step in that direction. `odoo.SUPERUSER_ID` still continues to work. odoo.api.SUPERUSER_ID is often used with Environment, so we declare both in the same package. task-4069446 closes odoo#182371 Related: odoo/upgrade-util#144 Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Move
odoo.SUPERUSER_ID
toodoo.api.SUPERUSER_ID
.In order to become a namespace package,
odoo
package should not contain any variables, only modules.odoo/upgrade-util#144
task-4069446
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr