Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Move SUPERUSER_ID to odoo.api #182371

Closed
wants to merge 1 commit into from

Conversation

kmagusiak
Copy link
Contributor

@kmagusiak kmagusiak commented Oct 1, 2024

Description of the issue/feature this PR addresses:
Move odoo.SUPERUSER_ID to odoo.api.SUPERUSER_ID.
In order to become a namespace package, odoo package should not contain any variables, only modules.

odoo/upgrade-util#144
task-4069446


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Oct 1, 2024

Pull request status dashboard

@kmagusiak kmagusiak changed the title Master init superuser krma Move SUPERUSER_ID to odoo.api Oct 1, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Oct 1, 2024
@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch from ac0fdd1 to b1c05ce Compare October 1, 2024 14:45
kmagusiak added a commit to odoo-dev/upgrade-util that referenced this pull request Oct 1, 2024
@kmagusiak kmagusiak marked this pull request as ready for review October 1, 2024 17:00
@C3POdoo C3POdoo requested review from a team, UemuS, hupo-odoo, rco-odoo, ryv-odoo and aab-odoo and removed request for a team October 1, 2024 17:02
kmagusiak added a commit to odoo-dev/upgrade-util that referenced this pull request Jan 24, 2025
@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch 3 times, most recently from be09a3a to 50ed925 Compare January 24, 2025 16:33
@kmagusiak kmagusiak marked this pull request as ready for review January 24, 2025 17:59
@kmagusiak
Copy link
Contributor Author

@rco-odoo @Julien00859 rebased and removed the necessity to do a mass update (kept some changes in base).

@C3POdoo C3POdoo requested review from a team and aab-odoo and removed request for a team January 24, 2025 18:01
Copy link
Member

@rco-odoo rco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only remark is about a comment 😉

odoo/orm/utils.py Outdated Show resolved Hide resolved
@rco-odoo
Copy link
Member

@robodoo delegate+

@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch from 50ed925 to 1f452f7 Compare January 27, 2025 16:41
In order to become a native namespace, `odoo` package must not contain
any variables. This is a step in that direction. `odoo.SUPERUSER_ID`
still continues to work.
odoo.api.SUPERUSER_ID is often used with Environment, so we declare both
in the same package.

task-4069446
@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch from 1f452f7 to fd08d4b Compare January 27, 2025 16:45
@kmagusiak
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 28, 2025
In order to become a native namespace, `odoo` package must not contain
any variables. This is a step in that direction. `odoo.SUPERUSER_ID`
still continues to work.
odoo.api.SUPERUSER_ID is often used with Environment, so we declare both
in the same package.

task-4069446

closes #182371

Related: odoo/upgrade-util#144
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
robodoo pushed a commit to odoo/upgrade-util that referenced this pull request Jan 28, 2025
odoo/odoo#182371

closes #144

Signed-off-by: Christophe Simonis (chs) <[email protected]>
@robodoo robodoo added the 18.2 label Jan 28, 2025
@robodoo robodoo closed this Jan 28, 2025
@kmagusiak kmagusiak deleted the master-init-superuser-krma branch January 28, 2025 07:30
julien-banken pushed a commit to odoo-dev/odoo that referenced this pull request Jan 28, 2025
In order to become a native namespace, `odoo` package must not contain
any variables. This is a step in that direction. `odoo.SUPERUSER_ID`
still continues to work.
odoo.api.SUPERUSER_ID is often used with Environment, so we declare both
in the same package.

task-4069446

closes odoo#182371

Related: odoo/upgrade-util#144
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
Deimort pushed a commit to odoo-dev/odoo that referenced this pull request Jan 30, 2025
In order to become a native namespace, `odoo` package must not contain
any variables. This is a step in that direction. `odoo.SUPERUSER_ID`
still continues to work.
odoo.api.SUPERUSER_ID is often used with Environment, so we declare both
in the same package.

task-4069446

closes odoo#182371

Related: odoo/upgrade-util#144
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18.2 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants