Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] core: move SUPERUSER_ID #144

Closed
wants to merge 1 commit into from

Conversation

kmagusiak
Copy link
Contributor

@robodoo
Copy link
Contributor

robodoo commented Oct 1, 2024

Pull request status dashboard

src/testing.py Outdated Show resolved Hide resolved
@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch from d614691 to 9a6804b Compare October 7, 2024 16:12
@KangOl
Copy link
Contributor

KangOl commented Oct 14, 2024

upgradeci retry with always only hr

@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch 2 times, most recently from 339fa66 to c432edd Compare October 25, 2024 11:53
@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch from c432edd to 0190f4a Compare December 10, 2024 09:10
@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch from 0190f4a to cb9ff93 Compare January 7, 2025 11:42
@kmagusiak kmagusiak force-pushed the master-init-superuser-krma branch from cb9ff93 to d1652b6 Compare January 24, 2025 16:05
Copy link
Member

@rco-odoo rco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kmagusiak
Copy link
Contributor Author

@KangOl Could you review and r+?

@kmagusiak kmagusiak requested a review from KangOl January 27, 2025 16:41
@KangOl
Copy link
Contributor

KangOl commented Jan 27, 2025

upgradeci retry

Copy link
Contributor

@KangOl KangOl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Contributor

robodoo commented Jan 27, 2025

@KangOl you may want to rebuild or fix this PR as it has failed CI.

@robodoo
Copy link
Contributor

robodoo commented Jan 27, 2025

@kmagusiak @KangOl linked pull request(s) odoo/odoo#182371 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit to odoo/odoo that referenced this pull request Jan 28, 2025
In order to become a native namespace, `odoo` package must not contain
any variables. This is a step in that direction. `odoo.SUPERUSER_ID`
still continues to work.
odoo.api.SUPERUSER_ID is often used with Environment, so we declare both
in the same package.

task-4069446

closes #182371

Related: odoo/upgrade-util#144
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
@robodoo robodoo closed this in e8516ae Jan 28, 2025
@robodoo robodoo added the 18.2 label Jan 28, 2025
@kmagusiak kmagusiak deleted the master-init-superuser-krma branch January 28, 2025 07:31
julien-banken pushed a commit to odoo-dev/odoo that referenced this pull request Jan 28, 2025
In order to become a native namespace, `odoo` package must not contain
any variables. This is a step in that direction. `odoo.SUPERUSER_ID`
still continues to work.
odoo.api.SUPERUSER_ID is often used with Environment, so we declare both
in the same package.

task-4069446

closes odoo#182371

Related: odoo/upgrade-util#144
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants