-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Prepare release v1.23.0/v0.117.0 #12043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetrybot
requested review from
mx-psi,
dmathieu,
a team,
evan-bradley,
bogdandrutu,
dmitryax and
andrzej-stencel
as code owners
January 7, 2025 18:13
dmitryax
approved these changes
Jan 7, 2025
songy23
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12043 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 455 455
Lines 24038 24038
=======================================
Hits 22037 22037
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Jan 7, 2025
not going to be merged
dmitryax
changed the title
TEMP-UNBLOCK-OTHER_PRs [chore] Prepare release v1.23.0/v0.117.0
[chore] Prepare release v1.23.0/v0.117.0
Jan 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
Apparently |
dmitryax
changed the title
[chore] Prepare release v1.23.0/v0.117.0
TMP-UNBLOCK-MERGE-FREEZE [chore] Prepare release v1.23.0/v0.117.0
Jan 7, 2025
dmitryax
changed the title
TMP-UNBLOCK-MERGE-FREEZE [chore] Prepare release v1.23.0/v0.117.0
[chore] TMP-UNBLOCK-MERGE-FREEZE Prepare release v1.23.0/v0.117.0
Jan 7, 2025
dmitryax
changed the title
[chore] TMP-UNBLOCK-MERGE-FREEZE Prepare release v1.23.0/v0.117.0
[chore] Prepare release v1.23.0/v0.117.0
Jan 7, 2025
Closing temporarily to unblock #12045 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
To unblock #12043, which is always rejected on the queue. Apparently, `github.event.merge_group.head_commit.author.name` is `OpenTelemetry Bot` not `opentelemetrybot`. See https://github.com/open-telemetry/opentelemetry-collector/actions/runs/12658978490/job/35277057933. Since `github.event.merge_group.head_commit.author` doesn't have `login` field, I've switched the condition to use the `name` field on both `github.event.pull_request.user` and `github.event.merge_group.head_commit.author`
bogdandrutu
approved these changes
Jan 7, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> #### Link to tracking issue Fixes # <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commands were run to prepare this release:
This PR also includes fix #12051 to reduce back-and-forths