[chore] Fix check merge freeze job #12045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
dmitryax
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12045 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 455 455
Lines 24038 24038
=======================================
Hits 22037 22037
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
dmitryax
changed the title
dmitryax
force-pushed
the
fix-check-merge-freeze
branch
from
a46c9b8 to
9b68d59
Compare
dmitryax
force-pushed
the
fix-check-merge-freeze
branch
from
9b68d59 to
4e7a8f0
Compare
songy23
added
release
release:retro
|
I verified the condition works now |
|
maybe close #12043 for now and reopen later? |
dmitryax
force-pushed
the
fix-check-merge-freeze
branch
from
4e7a8f0 to
94a8f03
Compare
dmitryax
force-pushed
the
fix-check-merge-freeze
branch
from
94a8f03 to
439426f
Compare
TylerHelmuth
approved these changes
Jan 7, 2025
codeboten
reviewed
Jan 7, 2025
songy23
approved these changes
Jan 7, 2025
Just typo. Thanks for catching. Updated |
Merged
via the queue into
open-telemetry:main
with commit Jan 7, 2025
7b804b5
44 of 45 checks passed
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Jan 7, 2025
In open-telemetry#12045, I assumed that `github.event.pull_request.user.name` would be present, but apparently it's not. So we need to switch back to using `github.event.pull_request.user.login`
|
Sorry for all the trouble @dmitryax... We weren't able to test the merge group check independently, but I should probably have seen this coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock #12043, which is always rejected on the queue.
Apparently,
github.event.merge_group.head_commit.author.nameisOpenTelemetry Botnotopentelemetrybot. See https://github.com/open-telemetry/opentelemetry-collector/actions/runs/12658978490/job/35277057933.Since
github.event.merge_group.head_commit.authordoesn't haveloginfield, I've switched the condition to use thenamefield on bothgithub.event.pull_request.userandgithub.event.merge_group.head_commit.author