[exporterhelper] New exporter helper for custom requests #8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
exporterhelper-v2
branch
2 times, most recently
from
43e39ea to
36d90a0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8178 +/- ##
==========================================
- Coverage 90.27% 90.16% -0.12%
==========================================
Files 301 302 +1
Lines 15596 15733 +137
==========================================
+ Hits 14080 14186 +106
- Misses 1227 1254 +27
- Partials 289 293 +4
☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
exporterhelper-v2
branch
4 times, most recently
from
d175cf6 to
e6e47f0
Compare
jmacd
approved these changes
Aug 16, 2023
Introduce a new exporter helper that operates over client-provided requests instead of pdata. The helper user now has to provide Converter - an interface with a function implementing translation of pdata Metrics/Traces/Logs into a user-defined Request. Request is an interface with only one required function Export. It opens a door for moving batching to the exporter, where batches will be built from client data format, instead of pdata. The batches can be properly sized by custom request size, which can be different from OTLP. The same custom request sizing will be applied to the sending queue. It will also improve the performance of the sending queue retries for non-OTLP exporters, they don't need to translate pdata on every retry.
dmitryax
force-pushed
the
exporterhelper-v2
branch
from
e6e47f0 to
4bc4b63
Compare
codeboten
reviewed
Aug 17, 2023
Co-authored-by: Alex Boten <[email protected]>
codeboten
reviewed
Aug 18, 2023
Co-authored-by: Alex Boten <[email protected]>
codeboten
approved these changes
Aug 18, 2023
jpkrohling
approved these changes
Aug 21, 2023
|
@codeboten, how did it happen to be added to 0.83.0? It should be part of 0.84.0, right? |
|
@dmitryax yeah sorry i tagged it incorrectly.... let me revisit the milestone labeling i did manually yesterday |
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Aug 25, 2023
The method was removed from the Request interface in open-telemetry#8178, so the implementation on the test structs is not required anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new exporter helper that operates over client-provided requests instead of pdata. The helper user now has to provide
Converter- an interface with a function implementing translation of pdata Metrics/Traces/Logs into a user-definedRequest.Requestis an interface with only one required functionExport.It opens a door for moving batching to the exporter, where batches will be built from client data format, instead of pdata. The batches can be properly sized by custom request size, which can be different from OTLP. The same custom request sizing will be applied to the sending queue. It will also improve the performance of the sending queue retries for non-OTLP exporters, they don't need to translate pdata on every retry.
This is an implementation alternative to #7874 as suggested in #7874 (comment)
Tracking Issue: #8122