Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve release workflow #767

Merged
merged 4 commits into from
Aug 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 16
registry-url: 'https://registry.npmjs.org'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.npmrc のセットアップをsetup-nodeにしてもらいます。

# Bootstrap lerna for building app before publishing
- name: restore lerna
uses: actions/cache@v3
Expand All @@ -30,17 +31,14 @@ jobs:
node_modules
*/*/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}-v2
- run: npm install -g npm@9
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--provenance で公開したいので npm9 にします。

- run: yarn install --frozen-lockfile
- run: npx lerna bootstrap -- --frozen-lockfile
- run: yarn lerna run --scope @openameba/spindle-hooks build
- name: Set git user
run: |
git config --global user.email "<>"
git config --global user.name "openameba"
- name: Log in to npm
run: |
echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc
npm whoami
git config --global user.name 'github-actions[bot]'
git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com'
Comment on lines +40 to +41
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コミットしたユーザーがGitHub Actionsのように表示されます。
openameba/ameba-color-palette.css#93 (comment)

- name: Extract branch from git ref
run: |
echo "::set-output name=name::${GITHUB_REF#refs/*/}"
Expand All @@ -51,6 +49,8 @@ jobs:
run: yarn lerna publish ${{ steps.extract_branch.outputs.version }} --conventional-commits --create-release github --yes --no-private
env:
GH_TOKEN: ${{ github.token }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.npmrc の設定を setup-node にしているため NODE_AUTH_TOKENNPM_TOKEN を指定しています。

NPM_CONFIG_PROVENANCE: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm から直接公開するのではないため --provenance の代わりに環境変数で対応します。

- name: Create Pull Request
run: >
curl
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh コマンドに変えようかと思いましたが、たしかAPI経由で実行しないとワークフローが実行されない関係でこの記述をしていた記憶があったのでとりあえず変更しませんでした。

Expand Down