Merge pull request #1019 from edx/iamosbanjaved/python38_failures

Fix python 3.8 failures

.travis.yml

@@ -58,10 +58,6 @@ matrix:
       env:
         TESTNAME=test-python-38
         TARGETS="PYTHON_ENV=py38 requirements.js test_python"
-  allow_failures:
-    - python: 3.8
-
-
 
 after_failure:
     # Print the list of running containers to rule out a killed container as a cause of failure

analytics_dashboard/courses/tests/test_views/__init__.py

@@ -3,7 +3,7 @@
 import json
 import logging
 
-from unittest.mock import _is_started, Mock, patch
+from unittest.mock import Mock, patch
 import httpretty
 from analyticsclient.exceptions import NotFoundError
 from ddt import data, ddt
@@ -343,8 +343,15 @@ def start_patching(self):
             _patch.start()
 
     def stop_patching(self):
-        for _patch in self.patches:
-            if _is_started(_patch):
+        # TODO: Just for the compatibility with python 3.5.
+        # Can be removed once support is dropped
+        try:
+            from unittest.mock import _is_started  # pylint: disable=import-outside-toplevel
+            for _patch in self.patches:
+                if _is_started(_patch):
+                    _patch.stop()
+        except ImportError:
+            for _patch in self.patches:
                 _patch.stop()
 
     def clear_patches(self):