Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-44257:fixing build s2i ruby test data inline with latest ruby version(>=3.0) #29378

Closed
wants to merge 2 commits into from
Closed

OCPBUGS-44257:fixing build s2i ruby test data inline with latest ruby version(>=3.0) #29378

wants to merge 2 commits into from

Conversation

prabhapa
Copy link

@prabhapa prabhapa commented Dec 16, 2024 •
edited
Loading

OCPBUGS-44257:fixing build s2i ruby test data inline with latest ruby version(>=3.0)

The test data for s2i image creation with source type as binary has issues post base image upgrade to ruby 3.0 (test/extended/testdata/builds/test-env-build.json) This is because webrick server is removed from default ruby libraries from 3.0 version,hence a webserver should be installed externally.The test data is missing this causing permanant failure post ruby 3.0 upgrade.

This fix is updating the test data with required dependencies to create a stable app to fulfill the testcase criteria.

signed-off by : prabhakar([email protected])

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 16, 2024
@openshift-ci-robot
Copy link

@prabhapa: This pull request references Jira Issue OCPBUGS-44257, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

OCPBUGS-44257:fixing build s2i ruby test data inline with latest ruby version(>=3.0)

The test data for s2i image creation with source type as binary has issues post base image upgrade to ruby 3.0 (test/extended/testdata/builds/test-env-build.json) This is because webrick server is removed from default ruby libraries from 3.0 version,hence a webserver should be installed externally.The test data is missing this causing permanant failure post ruby 3.0 upgrade.

This fix is updating the test data with required dependencies to create a stable app to fulfill the testcase criteria.

signed-off by : prabkakar([email protected])

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@prabhapa: This pull request references Jira Issue OCPBUGS-44257, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

… version(>=3.0)

The test data for s2i image creation with source type as binary has issues post base image upgrade to ruby 3.0 (test/extended/testdata/builds/test-env-build.json) This is because webrick server is removed from default ruby libraries from 3.0 version,hence a webserver should be installed externally.The test data is missing this causing permanant failure post ruby 3.0 upgrade.

This fix is updating the test data with required dependencies to create a stable app to fulfill the testcase criteria.

signed-off by : prabkakar([email protected])

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prabhapa
Copy link
Author

/retest e2e-gcp-ovn-builds

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@prabhapa: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aws-jenkins

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-image-registry

/test e2e-aws-ovn-microshift

/test e2e-aws-ovn-microshift-serial

/test e2e-aws-ovn-serial

/test e2e-gcp-ovn

/test e2e-gcp-ovn-builds

/test e2e-gcp-ovn-image-ecosystem

/test e2e-gcp-ovn-upgrade

/test e2e-metal-ipi-ovn-ipv6

/test images

/test lint

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback

/test e2e-agnostic-ovn-cmd

/test e2e-aws

/test e2e-aws-csi

/test e2e-aws-disruptive

/test e2e-aws-etcd-certrotation

/test e2e-aws-etcd-recovery

/test e2e-aws-ovn

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-ipsec-serial

/test e2e-aws-ovn-kube-apiserver-rollout

/test e2e-aws-ovn-kubevirt

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-single-node-serial

/test e2e-aws-ovn-single-node-techpreview

/test e2e-aws-ovn-single-node-techpreview-serial

/test e2e-aws-ovn-single-node-upgrade

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-upgrade-rollback

/test e2e-aws-ovn-upi

/test e2e-aws-ovn-virt-techpreview

/test e2e-aws-proxy

/test e2e-azure

/test e2e-azure-ovn-etcd-scaling

/test e2e-azure-ovn-upgrade

/test e2e-baremetalds-kubevirt

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-external-vsphere-ccm

/test e2e-gcp-csi

/test e2e-gcp-disruptive

/test e2e-gcp-fips-serial

/test e2e-gcp-ovn-etcd-scaling

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-techpreview-serial

/test e2e-hypershift-conformance

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-dualstack-local-gateway

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

/test e2e-metal-ipi-serial

/test e2e-metal-ipi-serial-ovn-ipv6

/test e2e-metal-ipi-virtualmedia

/test e2e-metal-ovn-single-node-live-iso

/test e2e-metal-ovn-single-node-with-worker-live-iso

/test e2e-openstack-ovn

/test e2e-openstack-serial

/test e2e-vsphere

/test e2e-vsphere-ovn-dualstack-primaryv6

/test e2e-vsphere-ovn-etcd-scaling

/test okd-e2e-gcp

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd

pull-ci-openshift-origin-master-e2e-aws-csi

pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2

pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones

pull-ci-openshift-origin-master-e2e-aws-ovn-fips

pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-master-e2e-aws-ovn-microshift

pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade

pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade

pull-ci-openshift-origin-master-e2e-gcp-csi

pull-ci-openshift-origin-master-e2e-gcp-ovn

pull-ci-openshift-origin-master-e2e-gcp-ovn-builds

pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade

pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade

pull-ci-openshift-origin-master-e2e-hypershift-conformance

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-master-e2e-openstack-ovn

pull-ci-openshift-origin-master-images

pull-ci-openshift-origin-master-lint

pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-origin-master-unit

pull-ci-openshift-origin-master-verify

pull-ci-openshift-origin-master-verify-deps

In response to this:

/retest e2e-gcp-ovn-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prabhapa
Copy link
Author

/test e2e-gcp-ovn-builds

5 similar comments
@prabhapa
Copy link
Author

/test e2e-gcp-ovn-builds

@prabhapa
Copy link
Author

/test e2e-gcp-ovn-builds

@prabhapa
Copy link
Author

/test e2e-gcp-ovn-builds

@prabhapa
Copy link
Author

/test e2e-gcp-ovn-builds

@prabhapa
Copy link
Author

/test e2e-gcp-ovn-builds

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Dec 17, 2024

Job Failure Risk Analysis for sha: c04366c

Job Name Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn IncompleteTests
Tests for this run (20) are below the historical average (572): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@prabhapa
OCPBUGS-44257:fixing build s2i ruby test data inline with latest ruby…
8b1cc86 
… version(>=3.0)

The test data for s2i image creation with source type as binary has issues post
base image upgrade to ruby 3.0 (test/extended/testdata/builds/test-env-build.json)
This is because webrick server is removed from default ruby libraries from 3.0
version,hence a webserver should be installed externally.The test data is missing
this causing permanant failure post ruby 3.0 upgrade.

This fix is updating the test data with required dependencies to create a stable
app to fulfill the testcase criteria.

signed-off by : prabhakar([email protected])
@prabhapa
OCPBUGS-44257:make update-bindata changes
5e4dd23
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@prabhapa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 5e4dd23 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial 5e4dd23 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-single-node-serial 5e4dd23 link false /test e2e-aws-ovn-single-node-serial
ci/prow/verify 5e4dd23 link true /test verify
ci/prow/e2e-agnostic-ovn-cmd 5e4dd23 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

adambkaplan
adambkaplan approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Moebasim @prabhapa as a follow up, I recommend submitting a pull request to add your GitHub IDs to the following OWNERS files as approvers. This will grant you permission to /approve pull requests for these parts of the repo.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan, prabhapa
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Dec 18, 2024

Job Failure Risk Analysis for sha: 5e4dd23

Job Name Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn IncompleteTests
Tests for this run (20) are below the historical average (455): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@adambkaplan
Copy link
Contributor

@prabhapa I'm inclined to close this in favor of #29355 - verify is failing on this one, and this is a test that has a 100% pass rate.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 23, 2024
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 24, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prabhapa
Copy link
Author

closing this in favour of #29355

@prabhapa prabhapa closed this Dec 24, 2024
@openshift-ci-robot
Copy link

@prabhapa: This pull request references Jira Issue OCPBUGS-44257. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-44257:fixing build s2i ruby test data inline with latest ruby version(>=3.0)

The test data for s2i image creation with source type as binary has issues post base image upgrade to ruby 3.0 (test/extended/testdata/builds/test-env-build.json) This is because webrick server is removed from default ruby libraries from 3.0 version,hence a webserver should be installed externally.The test data is missing this causing permanant failure post ruby 3.0 upgrade.

This fix is updating the test data with required dependencies to create a stable app to fulfill the testcase criteria.

signed-off by : prabhakar([email protected])

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

@divyansh42 divyansh42 Awaiting requested review from divyansh42

Assignees

@adambkaplan adambkaplan

Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prabhapa @openshift-ci-robot @adambkaplan @openshift-merge-robot