OCPBUGS-44257: Fixing build s2i ruby test data inline with latest ruby version(>=3.0) #29355
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@Moebasim: This pull request references Jira Issue OCPBUGS-44257, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/test e2e-gcp-ovn-builds |
|
Job Failure Risk Analysis for sha: cd9fa2b
|
|
Job Failure Risk Analysis for sha: cc9264c
|
|
Changes to test |
|
Job Failure Risk Analysis for sha: 71f1c19
|
|
Job Failure Risk Analysis for sha: d0e8944
|
|
Job Failure Risk Analysis for sha: be6865c
|
|
@Moebasim please squash your commits, then this one should be good to merge ( |
|
@Moebasim: This pull request references Jira Issue OCPBUGS-44257, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Moebasim
changed the title
|
@Moebasim: This pull request references Jira Issue OCPBUGS-44257, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
… version(>=3.0) The test data for s2i image creation with source type as binary has issues post base image upgrade to ruby 3.0 (test/extended/testdata/builds/test-env-build.json) This is because webrick server is removed from default ruby libraries from 3.0 version,hence a webserver should be installed externally.The test data is missing this causing permanant failure post ruby 3.0 upgrade. This fix is updating the test data with required dependencies to create a stable app to fulfill the testcase criteria. signed-off by : moebasim([email protected])
Moebasim
force-pushed
the
OCPBUGS-44257
branch
from
f22560d to
064b1c1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, Moebasim, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/retest e2e-aws-ovn-edge-zones |
|
@prabhapa: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Moebasim: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn-serial |
|
Job Failure Risk Analysis for sha: 064b1c1
|
openshift-merge-bot
bot
merged commit 929fc7c
into
openshift:master
|
@Moebasim: Jira Issue OCPBUGS-44257: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-44257 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
|
/cherry-pick release-4.18 |
|
/cherry-pick release-4.19 release-4.18 |
|
@Moebasim: new pull request could not be created: failed to create pull request against openshift/origin#release-4.19 from head openshift-cherrypick-robot:cherry-pick-29355-to-release-4.19: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.19 and openshift-cherrypick-robot:cherry-pick-29355-to-release-4.19"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.18 release-4.17 |
|
@Moebasim: new pull request created: #29390 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OCPBUGS-44257:fixing build s2i ruby test data inline with latest ruby version(>=3.0)
The test data for s2i image creation with source type as binary has issues post base image upgrade to ruby 3.0 (test/extended/testdata/builds/test-env-build.json) This is because webrick server is removed from default ruby libraries from 3.0 version,hence a webserver should be installed externally.The test data is missing this causing permanant failure post ruby 3.0 upgrade.
This fix is updating the test data with required dependencies to create a stable app to fulfill the testcase criteria.
signed-off by : moebasim([email protected])