Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-example: add missing dependencies #7600

Closed

Conversation

GeorgeSapkin
Copy link
Contributor

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile
  • Tested on: ath79/generic, OpenWrt 24.10.0-rc7 r28417-daef29c75d on TP-Link Archer C7 v2 βœ…
  • ( Preferred ) Mention: @andibraeu @cricalix
  • ( Preferred ) Screenshot or mp4 of changes:
  • Description:
    luci-app-example that's installed from 24.10.0-rc7 repos has non-working RPC examples due to missing dependencies used in applications/luci-app-example/root/usr/libexec/rpcd/luci.example. This PR adds the required dependencies to the app's Makefile.

@hnyman
Copy link
Contributor

hnyman commented Feb 2, 2025

The example app is supposed to be JavaScript based, so without lua.
Adding lua related dependencies looks wrong.

@GeorgeSapkin
Copy link
Contributor Author

GeorgeSapkin commented Feb 2, 2025

The example app is supposed to be JavaScript based, so without lua.
Adding lua related dependencies looks wrong.

The RPC examples (RPC Array Example, RPC JSONMap Table Example and RPC JSONMap Typed Example) call the mentioned lua script in applications/luci-app-example/root/usr/libexec/rpcd/luci.example and they don't work without the lua dependencies. Perhaps lua used to be included as part of something else in the past or the examples are not even meant to be installed through the package manager.

@systemcrash
Copy link
Contributor

Then this example app is outdated, and if it's to be an example of what openwrt currently promotes, then those calls should be (written in) ucode. lua is slowly being excised from openwrt. So the only thing for it is to remove anything lua based from the examples.

@GeorgeSapkin
Copy link
Contributor Author

@systemcrash I gave it a shot rewriting the lua part in ucode in a new PR: #7602

@GeorgeSapkin GeorgeSapkin deleted the fix-luci-app-example-deps branch February 3, 2025 03:32
@GeorgeSapkin GeorgeSapkin restored the fix-luci-app-example-deps branch February 3, 2025 13:59
@GeorgeSapkin GeorgeSapkin deleted the fix-luci-app-example-deps branch February 3, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants