luci-app-example: rewrite RPC side using ucode #7602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
systemcrash
reviewed
Feb 3, 2025
| @@ -0,0 +1,48 @@ | |||
| #!/usr/bin/env ucode | |||
There was a problem hiding this comment.
Technically, if we're to use the shebang and be able to call this uc file externally, set the +x bit on it also.
There was a problem hiding this comment.
Do ucode files under rpcd actually need a shebang? I can only find one example in luci-app-ddns which has it, but all ucode files outside of rpcd don't.
There was a problem hiding this comment.
They rpcd ones don't IIUC, but if the shebang is there, it's just good style and intention, so +x should likely also apply. The shebang likely aids testing also :)
Signed-off-by: George Sapkin <[email protected]>
GeorgeSapkin
force-pushed
the
rewrite-example-to-ucode
branch
from
b27b82a to
7227244
Compare
|
Merged. Thanks @GeorgeSapkin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefileluci-app-examplethat's installed from 24.10.0-rc7 repos has non-working RPC examples due to missing lua dependencies used inapplications/luci-app-example/root/usr/libexec/rpcd/luci.example. According to @systemcrash 0, lua is slowly being excised from openwrt. This PR rewrites the RPC side of the example app from lua to ucode, without touching the UI too much.