Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/class-properties): remove all *_if_super methods in static_block_and_prop_init #8104

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 25, 2024

Calling an intermediate function is not intutide, and these functions only have one line, so we can directly call it

Copy link
Member Author

Dunqing commented Dec 25, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #8104 will not alter performance

Comparing 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init (f54f48e) with 12-25-refactor_transformer_class-properties_move_supers_to_super_converter (d82fb52)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from 950754f to 58808bf Compare December 26, 2024 02:33
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from f5381c6 to 8ab86d0 Compare December 26, 2024 02:34
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from 58808bf to 97999dd Compare December 26, 2024 11:25
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from 8ab86d0 to 7b76a6f Compare December 26, 2024 11:25
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from 97999dd to 0027c8f Compare December 26, 2024 16:12
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from 7b76a6f to fb383a1 Compare December 26, 2024 16:12
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from 0027c8f to 4ce5b39 Compare December 26, 2024 16:41
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from fb383a1 to 4163963 Compare December 26, 2024 16:41
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from 4ce5b39 to c9eef21 Compare December 28, 2024 09:05
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from 4163963 to ebb98fa Compare December 28, 2024 09:05
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from c9eef21 to 275d4d7 Compare December 31, 2024 09:32
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from ebb98fa to 2a27f9a Compare December 31, 2024 09:33
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from 275d4d7 to 7580f6a Compare December 31, 2024 10:33
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from 2a27f9a to 41b4d78 Compare December 31, 2024 10:34
@Dunqing Dunqing marked this pull request as ready for review December 31, 2024 12:10
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 31, 2024
Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

…ds in `static_block_and_prop_init` (#8104)

Calling an intermediate function is not intutide, and these functions only have one line, so we can directly call it
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_move_supers_to_super_converter branch from 7580f6a to d82fb52 Compare December 31, 2024 12:33
@Dunqing Dunqing force-pushed the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch from 41b4d78 to f54f48e Compare December 31, 2024 12:33
Base automatically changed from 12-25-refactor_transformer_class-properties_move_supers_to_super_converter to main December 31, 2024 13:12
@graphite-app graphite-app bot merged commit f54f48e into main Dec 31, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 12-25-refactor_transformer_class-properties_remove_all__if_super_methods_in_static_block_and_prop_init branch December 31, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant