-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transformer/class-properties): transform super expressions and identifiers that refers to class binding in private method #8106
Merged
graphite-app
merged 1 commit into
main
from
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
Dec 31, 2024
Merged
feat(transformer/class-properties): transform super expressions and identifiers that refers to class binding in private method #8106
graphite-app
merged 1 commit into
main
from
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
Dec 31, 2024
+189
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 25, 2024
github-actions
bot
added
A-transformer
Area - Transformer / Transpiler
C-enhancement
Category - New feature or request
labels
Dec 25, 2024
CodSpeed Performance ReportMerging #8106 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 26, 2024 02:34
ee6fb67
to
cf82e06
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 26, 2024 02:34
363c423
to
8f5e0ee
Compare
This was referenced Dec 26, 2024
Merged
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 26, 2024 11:25
cf82e06
to
fee4053
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 26, 2024 11:25
8f5e0ee
to
4920a7c
Compare
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 26, 2024 16:12
fee4053
to
a9c7880
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 26, 2024 16:12
4920a7c
to
58745b8
Compare
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 26, 2024 16:41
a9c7880
to
d6f8d8b
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 26, 2024 16:41
58745b8
to
b1721d7
Compare
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 28, 2024 09:06
d6f8d8b
to
0453be9
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 28, 2024 09:06
b1721d7
to
ee6a73f
Compare
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 31, 2024 09:33
0453be9
to
68295cb
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 31, 2024 09:33
ee6a73f
to
4436fd7
Compare
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 31, 2024 10:34
68295cb
to
6a2ade6
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 31, 2024 10:34
4436fd7
to
97f4174
Compare
Merge activity
|
…dentifiers that refers to class binding in private method (#8106) All private methods will be moved out of class, so we need to transform all `super` expressions in private methods and transform identifiers that refer to class binding.
Dunqing
force-pushed
the
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
branch
from
December 31, 2024 12:34
6a2ade6
to
c786a13
Compare
Dunqing
force-pushed
the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
from
December 31, 2024 12:35
97f4174
to
0cc71cf
Compare
Base automatically changed from
12-25-refactor_transformer_class-properties_share_replace_class_name_with_temp_var_in_class_properties
to
main
December 31, 2024 13:16
graphite-app
bot
deleted the
12-25-feat_transformer_class-properties_transform_super_expressions_and_identifiers_that_refers_to_class_binding_in_private_method
branch
December 31, 2024 13:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-transformer
Area - Transformer / Transpiler
C-enhancement
Category - New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All private methods will be moved out of class, so we need to transform all
super
expressions in private methods and transform identifiers that refer to class binding.