Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-1156] a11y InputForm error message #6703

Merged
merged 8 commits into from
Feb 14, 2025

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request is adding the ignoreAccessibilityCheck prop to make the screen reader able to read InputForm error after closing the keyboard

List of changes proposed in this pull request

  • Updated the @pagopa/io-app-design-system dependency from version 4.5.2 to 4.5.5
  • Add ignoreAccessibilityCheck prop to IOScrollViewWithLargeHeader

How to test

  • Using a real device 📱, start a payment workflow
  • Turn on the TalkBack accessibility tool
  • In PAYMENT_CHECKOUT_INPUT_NOTICE_NUMBER screen, insert a wrong value and press on ✔️
  • Ensure that is reading the error
  • Check and ensure the same behavior in PAYMENT_CHECKOUT_INPUT_FISCAL_CODE screen

@LeleDallas LeleDallas added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Feb 11, 2025
@LeleDallas LeleDallas self-assigned this Feb 11, 2025
@LeleDallas LeleDallas changed the title fix: [IOBP-1163] a11yinput text error message fix: [IOBP-1163] a11y InputForm error message Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.00%. Comparing base (6e60dc2) to head (70f9dd1).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6703      +/-   ##
==========================================
+ Coverage   43.91%   50.00%   +6.09%     
==========================================
  Files        1417     1557     +140     
  Lines       30090    32446    +2356     
  Branches     6749     7345     +596     
==========================================
+ Hits        13213    16224    +3011     
+ Misses      16847    16170     -677     
- Partials       30       52      +22     
Files with missing lines Coverage Δ
ts/components/ui/IOScrollViewWithLargeHeader.tsx 87.87% <100.00%> (+6.62%) ⬆️
...out/screens/WalletPaymentInputFiscalCodeScreen.tsx 3.57% <ø> (ø)
...t/screens/WalletPaymentInputNoticeNumberScreen.tsx 6.89% <ø> (ø)

... and 354 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e60dc2...70f9dd1. Read the comment docs.

@LeleDallas LeleDallas changed the title fix: [IOBP-1163] a11y InputForm error message fix: [IOBP-1163] InputForm error message Feb 12, 2025
@LeleDallas LeleDallas changed the title fix: [IOBP-1163] InputForm error message fix: [IOBP-1163,IOBP-1156] a11y InputForm error message Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants