Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-1156] a11y InputForm error message #6703

Merged
merged 8 commits into from
Feb 14, 2025
Merged

fix: [IOBP-1156] a11y InputForm error message #6703

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ba9d296
chore: update design system
LeleDallas Feb 11, 2025
5730b58
feat: `ignoreAccessibilityCheck` to large scrollview
LeleDallas Feb 11, 2025
f92b24d
fix(payment): input form screen reader focus on error
LeleDallas Feb 11, 2025
2263374
Merge branch 'master' into IOBP-1163-fix-header-screen-reader
LeleDallas Feb 11, 2025
1ef33c4
test: update snapshot
LeleDallas Feb 12, 2025
035bac2
Merge branch 'master' into IOBP-1163-fix-header-screen-reader
LeleDallas Feb 12, 2025
a789bf3
Merge branch 'master' into IOBP-1163-fix-header-screen-reader
LeleDallas Feb 12, 2025
70f9dd1
Merge branch 'master' into IOBP-1163-fix-header-screen-reader
Hantex9 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@babel/plugin-transform-private-property-in-object": "^7.25.9",
"@babel/plugin-transform-react-jsx": "^7.25.9",
"@gorhom/bottom-sheet": "^4.1.5",
"@pagopa/io-app-design-system": "4.5.2",
"@pagopa/io-app-design-system": "4.5.5",
"@pagopa/io-pagopa-commons": "^3.1.0",
"@pagopa/io-react-native-cieid": "^0.3.5",
"@pagopa/io-react-native-crypto": "^1.0.1",
Expand Down
7 changes: 6 additions & 1 deletion ts/components/ui/IOScrollViewWithLargeHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ type Props = WithTestID<
headerActionsProp?: HeaderActionsProps;
canGoback?: boolean;
excludeEndContentMargin?: boolean;
ignoreAccessibilityCheck?: ComponentProps<
typeof HeaderSecondLevel
>["ignoreAccessibilityCheck"];
} & SupportRequestParams
>;

Expand All @@ -69,7 +72,8 @@ export const IOScrollViewWithLargeHeader = forwardRef<View, Props>(
includeContentMargins = false,
headerActionsProp = {},
excludeEndContentMargin,
testID
testID,
ignoreAccessibilityCheck = false
},
ref
) => {
Expand All @@ -93,6 +97,7 @@ export const IOScrollViewWithLargeHeader = forwardRef<View, Props>(

const headerProps: ComponentProps<typeof HeaderSecondLevel> = {
ignoreSafeAreaMargin,
ignoreAccessibilityCheck,
...useHeaderProps(
canGoback
? {
Expand Down
16 changes: 6 additions & 10 deletions ...res/messages/components/Home/__tests__/__snapshots__/TabNavigationContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is ARCH
false,
{
"backgroundColor": undefined,
"borderColor": "#BBC2D6",
"borderColor": undefined,
},
false,
false,
Expand Down Expand Up @@ -524,7 +524,6 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is ARCH
</RNSVGSvgView>
<Text
allowFontScaling={true}
dynamicTypeRamp="footnote"
maxFontSizeMultiplier={1.5}
style={
[
Expand All @@ -535,7 +534,7 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is ARCH
"fontSize": 14,
"fontStyle": "normal",
"fontWeight": "600",
"lineHeight": 21,
"lineHeight": undefined,
},
]
}
Expand Down Expand Up @@ -686,7 +685,6 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is ARCH
</RNSVGSvgView>
<Text
allowFontScaling={true}
dynamicTypeRamp="footnote"
maxFontSizeMultiplier={1.5}
style={
[
Expand All @@ -697,7 +695,7 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is ARCH
"fontSize": 14,
"fontStyle": "normal",
"fontWeight": "600",
"lineHeight": 21,
"lineHeight": undefined,
},
]
}
Expand Down Expand Up @@ -1260,7 +1258,6 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is INBO
</RNSVGSvgView>
<Text
allowFontScaling={true}
dynamicTypeRamp="footnote"
maxFontSizeMultiplier={1.5}
style={
[
Expand All @@ -1271,7 +1268,7 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is INBO
"fontSize": 14,
"fontStyle": "normal",
"fontWeight": "600",
"lineHeight": 21,
"lineHeight": undefined,
},
]
}
Expand Down Expand Up @@ -1352,7 +1349,7 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is INBO
false,
{
"backgroundColor": undefined,
"borderColor": "#BBC2D6",
"borderColor": undefined,
},
false,
false,
Expand Down Expand Up @@ -1422,7 +1419,6 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is INBO
</RNSVGSvgView>
<Text
allowFontScaling={true}
dynamicTypeRamp="footnote"
maxFontSizeMultiplier={1.5}
style={
[
Expand All @@ -1433,7 +1429,7 @@ exports[`TabNavigationContainer should match snapshot when shownCategory is INBO
"fontSize": 14,
"fontStyle": "normal",
"fontWeight": "600",
"lineHeight": 21,
"lineHeight": undefined,
},
]
}
Expand Down
2 changes: 2 additions & 0 deletions ts/features/payments/checkout/screens/WalletPaymentInputFiscalCodeScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ const WalletPaymentInputFiscalCodeScreen = () => {
label: I18n.t("wallet.payment.manual.fiscalCode.title")
}}
description={I18n.t("wallet.payment.manual.fiscalCode.subtitle")}
ignoreAccessibilityCheck
canGoback
headerActionsProp={{ showHelp: true }}
contextualHelp={emptyContextualHelp}
actions={
Platform.OS === "android"
Expand Down
1 change: 1 addition & 0 deletions ts/features/payments/checkout/screens/WalletPaymentInputNoticeNumberScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const WalletPaymentInputNoticeNumberScreen = () => {
return (
<>
<IOScrollViewWithLargeHeader
ignoreAccessibilityCheck
title={{
label: I18n.t("wallet.payment.manual.noticeNumber.title")
}}
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3753,9 +3753,9 @@ __metadata:
languageName: node
linkType: hard

"@pagopa/io-app-design-system@npm:4.5.2":
version: 4.5.2
resolution: "@pagopa/io-app-design-system@npm:4.5.2"
"@pagopa/io-app-design-system@npm:4.5.5":
version: 4.5.5
resolution: "@pagopa/io-app-design-system@npm:4.5.5"
dependencies:
"@testing-library/jest-native": ^5.4.2
"@types/react-test-renderer": ^18.0.0
Expand All @@ -3779,7 +3779,7 @@ __metadata:
react-native-reanimated: "*"
react-native-safe-area-context: "*"
react-native-svg: "*"
checksum: fb7a07d7c4b714220ce5c54870ea9691989cf424f634ff4d7fc3ce4ecd66cdba6b211a86ce0854c6b1ec023027c835e23546f686e06938b78e742df0bfe5858e
checksum: 01519ebe0e72a572f1298e26d61d754d8126fae217f2b304a0873376b817f3124cac3d630efd6c6c1208f319363505760bb04d3784ff942ced6903815bf4d415
languageName: node
linkType: hard

Expand Down Expand Up @@ -13657,7 +13657,7 @@ __metadata:
"@babel/runtime": ^7.20.0
"@gorhom/bottom-sheet": ^4.1.5
"@jambit/eslint-plugin-typed-redux-saga": ^0.4.0
"@pagopa/io-app-design-system": 4.5.2
"@pagopa/io-app-design-system": 4.5.5
"@pagopa/io-pagopa-commons": ^3.1.0
"@pagopa/io-react-native-cieid": ^0.3.5
"@pagopa/io-react-native-crypto": ^1.0.1
Expand Down
Loading