Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-2634] Implement Zendesk FAQ Banner in the accesso_a_io subCategories screen #6714

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Feb 13, 2025

Important

Depends on this PR on io-services-metadata

Short description

This PR updates the content definition url source and implements the Zendesk sub categories Banner visualization in relation to the subCategories configuration.

List of changes proposed in this pull request

  • Updated the content definition url in the scripts/generate-api-models.sh file
  • Integrated the Banner educational in the ts/features/zendesk/screens/ZendeskChooseSubCategory.tsx screen

Demo

iOS Android
iOS-zendesk-faq-banner.mp4
android-zendesk-faq-banner.mp4

How to test

This scenario can be tested in the local environment.
Run the io-dev-api-server from this branch, then repeat the steps shown in the demo videos and ensure that everything works properly.

@ChrisMattew ChrisMattew self-assigned this Feb 13, 2025
@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Feb 13, 2025
Copy link
Contributor

github-actions bot commented Feb 13, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.08%. Comparing base (ca154f3) to head (6030bfe).

Files with missing lines Patch % Lines
...tures/zendesk/screens/ZendeskChooseSubCategory.tsx 30.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6714      +/-   ##
==========================================
- Coverage   50.08%   50.08%   -0.01%     
==========================================
  Files        1557     1557              
  Lines       32462    32471       +9     
  Branches     7302     7354      +52     
==========================================
+ Hits        16259    16262       +3     
+ Misses      16163    16157       -6     
- Partials       40       52      +12     
Files with missing lines Coverage Δ
...tures/zendesk/screens/ZendeskChooseSubCategory.tsx 65.71% <30.00%> (-11.21%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca154f3...6030bfe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge ✋ IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants