Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-2664] Change session expired card component #6720

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Feb 14, 2025

Short description

This pull request involves the addition of a new component for the session expired state. The changes include updates to localization files, the addition of a new help center URL, and modifications to the LandingScreen component.

Details

🤖 🍏
-.a11y.mp4
-.a11y.MP4
MP

List of changes proposed in this pull request

Codebase Enhancements:

  • ts/config.ts: Added a new constant for the help center URL related to session expiration.
  • ts/screens/authentication/LandingScreen.tsx:
    • Imported new hooks and constants.
    • Replaced the LandingCardComponent with the new LandingSessionExpiredComponent.
    • Added logic to handle the new button link for session expiration. [1] [2] [3] [4] [5] [6] [7] [8]

New Component:

Testing:

Analytics:

How to test

  • Trigger a session expiration event and navigate to the landing page.
  • Verify that the landing page displays the new session expired component.
  • Test the new component a11y on both Android and iOS physical devices.
  • Tap on the CTA and ensure it redirects to this page.
  • Validate that the MP event is correctly sent upon tapping the CTA.

@shadowsheep1 shadowsheep1 added dont-merge ✋ IO-A&I IO - Autenticazione e Identità copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. labels Feb 14, 2025
@shadowsheep1 shadowsheep1 self-assigned this Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@shadowsheep1
Copy link
Member Author

@mariateresaventura copy review needed 🙏

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.29%. Comparing base (90cfeb1) to head (b6673fc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/screens/authentication/LandingScreen.tsx 28.57% 5 Missing ⚠️
ts/utils/analytics.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6720   +/-   ##
=======================================
  Coverage   50.28%   50.29%           
=======================================
  Files        1558     1559    +1     
  Lines       32477    32495   +18     
  Branches     7363     7316   -47     
=======================================
+ Hits        16330    16342   +12     
- Misses      16094    16111   +17     
+ Partials       53       42   -11     
Files with missing lines Coverage Δ
ts/config.ts 100.00% <100.00%> (ø)
...tion/components/LandingSessionExpiredComponent.tsx 100.00% <100.00%> (ø)
ts/utils/analytics.ts 35.00% <0.00%> (-1.21%) ⬇️
ts/screens/authentication/LandingScreen.tsx 76.84% <28.57%> (-3.60%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90cfeb1...b6673fc. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@shadowsheep1 shadowsheep1 added legal-approved ⚖️ ✅ this PR has legal compliance and removed legal-review-needed ⚖️ ⛔ this PR is under legal check. dont-merge ✋ labels Feb 19, 2025
@shadowsheep1 shadowsheep1 added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit 73f2d47 Feb 19, 2025
22 checks passed
@shadowsheep1 shadowsheep1 deleted the IOPID-2664-session-expired branch February 19, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità legal-approved ⚖️ ✅ this PR has legal compliance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants