-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOPID-2664] Change session expired card component #6720
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
@mariateresaventura copy review needed 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6720 +/- ##
=======================================
Coverage 50.28% 50.29%
=======================================
Files 1558 1559 +1
Lines 32477 32495 +18
Branches 7363 7316 -47
=======================================
+ Hits 16330 16342 +12
- Misses 16094 16111 +17
+ Partials 53 42 -11
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Short description
This pull request involves the addition of a new component for the session expired state. The changes include updates to localization files, the addition of a new help center URL, and modifications to the
LandingScreen
component.Details
-.a11y.mp4
-.a11y.MP4
List of changes proposed in this pull request
Codebase Enhancements:
ts/config.ts
: Added a new constant for the help center URL related to session expiration.ts/screens/authentication/LandingScreen.tsx
:LandingCardComponent
with the newLandingSessionExpiredComponent
.New Component:
ts/screens/authentication/components/LandingSessionExpiredComponent.tsx
: Created a new component to handle the session expired state with an optional button link.Testing:
ts/screens/authentication/__tests__/LandingSessionExpiredComponent.test.tsx
: Added tests for the newLandingSessionExpiredComponent
.Analytics:
ts/utils/analytics.ts
: Added a new function to track help center CTA taps.How to test