Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Buttons colors for V2 #243

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Removed Buttons colors for V2 #243

merged 8 commits into from
Jan 22, 2024

Conversation

stechiu
Copy link
Contributor

@stechiu stechiu commented Jan 16, 2024

Reason for changes

We will remove the deprecated colors in V2

Summary of changes

  • Removed .black, .silver, .blue, and .darkBlue as per QL button redesign requirements

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu stechiu requested a review from a team as a code owner January 16, 2024 21:48
scannillo
scannillo reviewed Jan 16, 2024
View reviewed changes
UnitTests/PaymentButtonsTests/PayPalCreditButton_Tests.swift Outdated
@@ -14,7 +14,7 @@ class PayPalCreditButton_Tests: XCTestCase {
let sut = PayPalCreditButton()
XCTAssertEqual(sut.edges, PaymentButtonEdges.softEdges)
XCTAssertEqual(sut.size, PaymentButtonSize.collapsed)
XCTAssertEqual(sut.color, PaymentButtonColor.darkBlue)
XCTAssertEqual(sut.color, PaymentButtonColor.white)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming, should white or gold be the default color?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I just checked Figma and gold is the recommended/default color. Will make that update :)

@warmkesselj
Copy link
Collaborator

@stechiu does this enum embedded in PayPalButton need updating?

    /// Available colors for PayPalButton.
    public enum Color: String {
        case gold
        case white
        case black
        case silver
        case blue

        var color: PaymentButtonColor {
            PaymentButtonColor(rawValue: rawValue) ?? .gold
        }
    }

@stechiu
Copy link
Contributor Author

stechiu commented Jan 18, 2024

@stechiu does this enum embedded in PayPalButton need updating?

    /// Available colors for PayPalButton.
    public enum Color: String {
        case gold
        case white
        case black
        case silver
        case blue

        var color: PaymentButtonColor {
            PaymentButtonColor(rawValue: rawValue) ?? .gold
        }
    }

Missed this one, thanks!

@jaxdesmarais
Copy link
Collaborator

It looks like we will also need to clean up the demo app with these changes. See:

paypal-ios/Demo/Demo/Extensions/PaymentButtonEnums+Extension.swift

Line 14 in 157712a

extension PayPalButton.Color: CaseIterable {

richherrera
richherrera approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@richherrera richherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the feedback from the rest of the team, it LGTM!!!

Sources/PaymentButtons/PaymentButton+ImageAsset.swift Show resolved Hide resolved
Sources/PaymentButtons/PaymentButtonColor.swift Show resolved Hide resolved
@richherrera richherrera mentioned this pull request Jan 19, 2024
Merged
1 task
warmkesselj
warmkesselj approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@warmkesselj warmkesselj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stechiu stechiu merged commit 9970d01 into next-major-version Jan 22, 2024
4 checks passed
@stechiu stechiu deleted the button-color-v2 branch January 22, 2024 20:05
@stechiu stechiu mentioned this pull request Feb 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais left review comments

@scannillo scannillo scannillo left review comments

@richherrera richherrera richherrera approved these changes

@warmkesselj warmkesselj warmkesselj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stechiu @warmkesselj @jaxdesmarais @scannillo @richherrera