Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log SDK Integration Source #140

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Log SDK Integration Source #140

merged 3 commits into from
Feb 12, 2024

Conversation

nbierdeman
Copy link
Contributor

@nbierdeman nbierdeman commented Feb 9, 2024

Description

Herein lies part of the effort charged by DTPPCPSDK-1482.

Why are we making these changes?

We are going to use these new constants for logging the JS SDK data-sdk-integration-source values.

Dependent changes

This needs to be released before paypal/react-paypal-js#420 will work.

@nbierdeman nbierdeman marked this pull request as ready for review February 9, 2024 17:28
@nbierdeman nbierdeman requested a review from a team as a code owner February 9, 2024 17:28
Copy link
Contributor

@jshawl jshawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

src/params.js Show resolved Hide resolved
@nbierdeman nbierdeman merged commit 3ddd1fe into main Feb 12, 2024
1 check passed
@nbierdeman nbierdeman deleted the feature/DTPPCPSDK-1482 branch February 12, 2024 19:15
@nbierdeman nbierdeman mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants