-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken references and user permission check in "react-company-templates" #1378
Conversation
Hey @hugoabernier 👋 |
Anyone down on this? Please let me know if I have to do anything else... |
No, you don't need to do anything else but be patient. We usually process the PRs every other weekend. |
Thanks for your support, @hugoabernier! 🙌 |
Thank you @tmaestrini for your update (and your patience)! Awesome!. Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
Many thanks to you, @hugoabernier! 🚀 |
What's in this Pull Request?
This PR fixes three incorrect references due to copy-paste errors in the solution template used by the author. Moreover, it addresses an erroneous user permission check to set the correct visibility of the command and "prettifies" some declarations.
That said, it changes
There was no security issue in this extension before – the current permission fix implements better user experience: it now hides the command button for any user that has no permission to add documents to the library.
Nevertheless, this update is necessary, otherwise the solution can cause side effects due to incorrect references when using it in production.