-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add beta testnet genesis #8
Conversation
"app_state": { | ||
"application": { | ||
"applicationList": [], | ||
"application_list": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting. We only have applicationList
in the original config.yml. Don't know where application_list
is coming from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change applicationList
to application_list
in config.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto for all other camel cased configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel comfortable changing this right now.
- Not all modules have repeating fields (in different cases) and I don't know why
- The code might expect a particular field - and I need to understand which one before removing another
- Missing field might cause an issue
- This can be removed with an upgrade in the future if necessary
@@ -0,0 +1,5 @@ | |||
broadcast-mode = "sync" | |||
chain-id = "poktroll" | |||
keyring-backend = "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on renaming this to beta?
Sounds cool but I'm afraid it'll force us to change all our docs. If my assumption is correct, let's leave it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing keyring backend indeed will require us changing the docs (even replacing it with file
like morse). I'm not sure if we should do it.
- Regular users won't care as they use different wallets;
- Production deployments will opt in to use a different backend: https://docs.cosmos.network/main/user/run-node/keyring#the-pass-backend
"inflation": "0.130000000000000000" | ||
}, | ||
"params": { | ||
"blocks_per_year": "6311520", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's our current block time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is mint
module. I suppose this is used to reward validators. IIRC, we're not going to inflate the network with validator rewards, only with relay service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nuanced answer. You're both right & wrong at the same time but we'll cover that offline.
@Olshansk updated ReadMe and rolled back the |
@okdas I'm creating [1] to keep track of this. |
Used the following
config.yml
, plus authz authorizations.