-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Filter Suppliers by ServiceID #1028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Olshansk, I tested it on localnet and it works great 👍
Left a few commands but LGTM otherwise.
Also, could you please adapt:
x/supplier/config/supplier_configs_reader_test.go
x/tokenomics/keeper/token_logic_modules_test.go
To use uint32
too.
@red-0ne Appreciate the detailed review. Take a look at the changes I pushed. Thought you'd appreciate it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 1028) |
@bryanchriswhite @red-0ne I'm going to merge this in to unblock work and keep moving, but wanted to call out this specific change that I'm making in the return queries:
@bryanchriswhite This is just an FYI, but feel free to review this after the fact and leave any additional comments. My goal was to not have your review being a blocker in getting this in. |
Summary
Update the supplier query endpoint to use AutoCLI and add a flag to filter by
ServiceID
Primary Changes:
service_id
filter tolist-suppliers
query to support filtering suppliers by service IDlist-supplier
tolist-suppliers
for improved clarityfloat32
touint32
to fix autoCLI issuesSecondary changes:
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist