Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Enable to set the number of lidar rays in navigation, discovery and flocking scenarios #141

Merged
merged 6 commits into from
Sep 17, 2024
Merged

[Feature] Enable to set the number of lidar rays in navigation, discovery and flocking scenarios #141

merged 6 commits into from
Sep 17, 2024

Conversation

Giovannibriglia
Copy link
Contributor

Fixes #140

@matteobettini matteobettini changed the title Enable to set the number of lidar rays in navigation, discovery and flocking scenarios [Feature] Enable to set the number of lidar rays in navigation, discovery and flocking scenarios Sep 17, 2024
@matteobettini matteobettini added the enhancement New feature or request label Sep 17, 2024
matteobettini
matteobettini approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left a few changes

vmas/scenarios/discovery.py Outdated Show resolved Hide resolved
vmas/scenarios/flocking.py Outdated Show resolved Hide resolved
vmas/scenarios/navigation.py Outdated Show resolved Hide resolved
@Giovannibriglia
Copy link
Contributor Author

Thank youuu :), sorry for the incoveniences :(

@matteobettini matteobettini merged commit 26ceb42 into proroklab:main Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteobettini matteobettini matteobettini approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Give the possibility to set "n_rays" Lidar in Navigation-Discovery-Flocking scenarios
2 participants
@Giovannibriglia @matteobettini