Skip to content

Commit

Permalink
clean up; no functional changes
Browse files Browse the repository at this point in the history
  • Loading branch information
psnider committed Mar 28, 2022
1 parent 4522dfa commit d8744d6
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 17 deletions.
12 changes: 6 additions & 6 deletions ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,15 @@ Note that the TypeScript is in the sibling file of the same basename.
Since this was a project for me to learn Aurelia,
I didn't get around to writing tests.

If this web-app winds up being something that I use for a production deployment, then I'll add appropriate tests then.
In the meantime, I'll revisit both the ReactJS and Vue.js web-apps, and I may even consider other frameworks, such as Svelte and Hyper-HTML.
If this web-app winds up being something that I use for a production deployment, then I'll add appropriate tests.
In the meantime, I'll revisit both the ReactJS and Vue.js web-apps, and I may even consider other frameworks, such as Svelte or Hyper-HTML. (I've used both Angular 1 and 2 in the past, and find them too complicated.)

## Two main test categories
I like to divide tests into two groups:
- independent of the network
- those independent of the network
These test all normal computation, and use mocks to test local code.
- requires the internet
This may have dependencies on external services, which may fail.
- those that require the internet
These may have dependencies on external services, which may fail.

I like test frameworks that support alternatives to pass/fail.
For example, mocha support skip(), which causes tests to show up in test results, but as not having been run.
Expand All @@ -171,5 +171,5 @@ Errors in required filenames are not flagged. This can cause a fair bit of pain
The project moves along very slowly.
This is the 3rd time I tried Aurelia! Both of the previous times, my project wound up dying due to tooling and documentation problems.
- It's easy to confuse Aurelia v1 and v2 documentation.
But this is also true of React JS and Vue.js, which both have a number of complicating revisions and usage models.
But this is also true of React JS and Vue.js, and probably even worse. Both have a number of complicating revisions and usage models.

File renamed without changes.
2 changes: 1 addition & 1 deletion dist/index.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<!doctype html><html style="height:100%;width:100%;"><head><meta charset="utf-8"><title>License Plate Game</title><meta name="viewport" content="width=device-width,initial-scale=1"><base href="/"><link rel="icon" href="favicon.ico"><script defer="defer" src="/runtime~app.450b9e5fc6deafa566fa.bundle.js"></script><script defer="defer" src="/vendors-7e9c6a9f.1adc9f385b3ac86c2788.bundle.js"></script><script defer="defer" src="/vendors-319a6989.a80424c5fae4edbd79e3.bundle.js"></script><script defer="defer" src="/vendors-4e64aa37.9e9c6bc89f49649635e3.bundle.js"></script><script defer="defer" src="/vendors-3ce50090.b281a0f6725a5f032f6a.bundle.js"></script><script defer="defer" src="/vendors-fcadf5bb.99541182c2a6c79ed0a2.bundle.js"></script><script defer="defer" src="/vendors-cdd60c62.abf102d6ed9d6bb32f06.bundle.js"></script><script defer="defer" src="/app.f8fb41402d0db25cc1c0.bundle.js"></script></head><body aurelia-app="main"></body></html>
<!doctype html><html style="height:100%;width:100%;"><head><meta charset="utf-8"><title>License Plate Game</title><meta name="viewport" content="width=device-width,initial-scale=1"><base href="/"><link rel="icon" href="favicon.ico"><script defer="defer" src="/runtime~app.450b9e5fc6deafa566fa.bundle.js"></script><script defer="defer" src="/vendors-7e9c6a9f.1adc9f385b3ac86c2788.bundle.js"></script><script defer="defer" src="/vendors-319a6989.a80424c5fae4edbd79e3.bundle.js"></script><script defer="defer" src="/vendors-4e64aa37.9e9c6bc89f49649635e3.bundle.js"></script><script defer="defer" src="/vendors-3ce50090.b281a0f6725a5f032f6a.bundle.js"></script><script defer="defer" src="/vendors-fcadf5bb.99541182c2a6c79ed0a2.bundle.js"></script><script defer="defer" src="/vendors-cdd60c62.abf102d6ed9d6bb32f06.bundle.js"></script><script defer="defer" src="/app.2a33eb2b9c39d82e4716.bundle.js"></script></head><body aurelia-app="main"></body></html>
3 changes: 1 addition & 2 deletions src/AnswerDifficulty.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {bindable, autoinject, observable} from 'aurelia-framework';
import type { PuzzleAnswer } from "./lib/index.d"
import {bindable, autoinject} from 'aurelia-framework';


@autoinject
Expand Down
2 changes: 1 addition & 1 deletion src/AnswerScores.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {bindable, autoinject, observable} from 'aurelia-framework';
import {bindable, autoinject} from 'aurelia-framework';


@autoinject
Expand Down
1 change: 0 additions & 1 deletion src/AnswersPanel.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {autoinject, bindable, observable} from 'aurelia-framework';
import {EventAggregator} from 'aurelia-event-aggregator';
import type { PuzzleAnswer } from "./lib"
import {AuMsgAnswersPanelState} from './messages';


@autoinject
Expand Down
1 change: 0 additions & 1 deletion src/InProcessIndicator.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import {bindable} from 'aurelia-framework';


export class InProcessIndicator {
Expand Down
4 changes: 1 addition & 3 deletions src/app.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import {autoinject} from 'aurelia-framework';
import {EventAggregator} from 'aurelia-event-aggregator';
// import {Router, RouterConfiguration} from 'aurelia-router';
// import {PLATFORM} from 'aurelia-pal';
import {Settings, ExpiringMessage, PuzzleAnswer} from "./lib/index.d"
import {MAX_EXPIRATION_SECONDS} from "./lib/lib"
import {AuMsgAboutPanelState, AuMsgFeedbackPanelState, AuMsgRemoteCallState, AuMsgNewGameRequest, AuMsgCheckAnswer, AuMsgHintRequest, AuMsgResetPuzzleText} from './messages';
import {AuMsgAboutPanelState, AuMsgFeedbackPanelState, AuMsgRemoteCallState, AuMsgNewGameRequest, AuMsgCheckAnswer, AuMsgHintRequest} from './messages';
import {LicensePlatePuzzle} from "./lib/license-plate-puzzle"
import {LicensePlateGameClient} from "license-plate-game-api"
import type {LicensePlateGameAPI} from "license-plate-game-api"
Expand Down
1 change: 0 additions & 1 deletion src/expiring-messages.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { ids } from "webpack"
import type {ExpiringMessage} from "./lib/index.d"
import {MAX_EXPIRATION_SECONDS} from "./lib/lib"

Expand Down
3 changes: 2 additions & 1 deletion src/jsfiddles.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- sliding text transition
https://jsfiddle.net/3zp19wjq/1/
- blurring texxt
- blurring text
...

0 comments on commit d8744d6

Please sign in to comment.