build: batch update javascript dependencies #839

afuetterer · 2023-11-23T18:19:35Z

Description

Next try.

This PR proposes the following changes:

update the Javascript dependencies in multiple grouped commits
alter the dependabot config slightly (move copy-webpack-plugin to the more fitting webpack update group
update the used versions of eslint and react plugin in pre-commit config
take a screenshot during frontend testing

Types of Changes

Build related changes

Checklist

I have read the contributor guide.
My code follows the code style of this project.
All new and existing tests passed.

Tasks

pin react-bootstrap
ignore updates for react-bootstrap

MyPyDavid · 2023-11-24T10:49:22Z

thank you, Ive installed the wheel.

Looks like there is a bug with the icons?

Catalogs

MyPyDavid · 2023-11-24T10:51:06Z

and in the edit form:

Edit catalog

MyPyDavid · 2023-11-24T10:57:30Z

Is this a bug in my setup with missing static files or from this new build? Do you have an idea @jochenklar?

afuetterer · 2023-11-24T11:35:32Z

Can you try with a wheel from another PR, that did not touch the frontend dependencies?
Maybe this one: #833

Does 833 have icons?

afuetterer · 2023-11-24T11:37:07Z

But the frontend does work in principle? You can click around, the buttons are working? I mean the frontend tests test exactly that.

It is "just" a matter of the icons, yes?

MyPyDavid · 2023-11-24T13:41:20Z

yes the front-end was working fine and everthing is clickable.
Now with the #833 it looks normal

afuetterer · 2023-11-24T13:54:24Z

Alright.
I did not build the frontend. There are a couple of changes in this PR. Maybe its a problem with the webpack bundle.

@jochenklar: Which library supplies the icons?

jochenklar · 2023-11-24T14:08:29Z

I am not 100% which items you mean, but we use font awesome 4 icons. These are not bundled by webpack, yet but are included here: https://github.com/rdmorganiser/rdmo/blob/master/rdmo/core/templates/core/base.html#L9 (old school).

afuetterer · 2023-11-24T14:15:40Z

I mean the missing icons @MyPyDavid mentioned.

Should font awesome be downloaded before building the wheel?

The build wheel does the steps, documented here:
https://rdmo.readthedocs.io/en/latest/development/releases.html

That would not make sense, if they were present in 833.

Did you run collectstatic @MyPyDavid?

jochenklar · 2023-11-24T14:17:03Z

Maybe @MyPyDavid forgot download_vendor_files?

afuetterer · 2023-11-24T14:25:51Z

download_vendor_files is supposed to called after installing rdmo, right? So these vendor files should not be in the wheel, correct?

MyPyDavid · 2023-11-24T14:27:42Z

I re-did download_vendor_files

24 Failed to decode downloaded font: <URL>
24 OTS parsing error: invalid sfntVersion: 1702391919

package.json

Bumps the babel group with 5 updates: | Package | From | To | | --- | --- | --- | | [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) | `7.17.10` | `7.23.4` | | [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.17.10` | `7.23.3` | | [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) | `7.17.10` | `7.23.3` | | [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) | `7.16.7` | `7.23.3` | | [babel-loader](https://github.com/babel/babel-loader) | `8.2.5` | `9.1.3` | Updates `@babel/cli` from 7.17.10 to 7.23.4 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.4/packages/babel-cli) Updates `@babel/core` from 7.17.10 to 7.23.3 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-core) Updates `@babel/preset-env` from 7.17.10 to 7.23.3 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-preset-env) Updates `@babel/preset-react` from 7.16.7 to 7.23.3 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-preset-react) Updates `babel-loader` from 8.2.5 to 9.1.3 - [Release notes](https://github.com/babel/babel-loader/releases) - [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md) - [Commits](babel/babel-loader@v8.2.5...v9.1.3) --- updated-dependencies: - dependency-name: "@babel/cli" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: babel - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: babel - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: babel - dependency-name: "@babel/preset-react" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: babel - dependency-name: babel-loader dependency-type: direct:development update-type: version-update:semver-major dependency-group: babel ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Dependabot couldn't find the original pull request head commit, 9d6cdbe. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

afuetterer · 2023-11-30T08:57:04Z

@MyPyDavid: Can we merge this now to take smaller steps?
This PR updates the update config and a few js libraries.

Also I added a screenshot of one of the frontend pages, like you requested.

See: https://github.com/rdmorganiser/rdmo/suites/18626099409/artifacts/1083008649

Icons are still working.

Let's continue from this save step with smaller increments and find the dependency that hides the icons. Maybe it really was react-bootstrap, which I pinned in this PR.

What do you think?

afuetterer · 2023-11-30T21:34:48Z

New screenshot: https://github.com/rdmorganiser/rdmo/suites/18649184672/artifacts/1084685564

afuetterer · 2023-11-30T21:36:02Z

If you approve, let's merge this.

MyPyDavid

very nice, thank you!

afuetterer · 2023-12-01T09:42:29Z

Thanks, took me long enough.

Let's get this into dependency-updates and then into dev.

afuetterer requested a review from MyPyDavid November 23, 2023 18:19

afuetterer mentioned this pull request Nov 23, 2023

build: batch update javascript dependencies #837

Closed

4 tasks

This comment was marked as resolved.

Sign in to view

afuetterer added the type:maintenance label Nov 24, 2023

This comment was marked as resolved.

Sign in to view

afuetterer added javascript Pull requests that update Javascript code dependencies Pull requests that update a dependency file labels Nov 27, 2023

MyPyDavid reviewed Nov 27, 2023

View reviewed changes

package.json Show resolved Hide resolved

afuetterer and others added 2 commits November 29, 2023 06:49

ci: update dependabot js groups

0e95d6a

afuetterer force-pushed the update-js-dependencies branch from b28615a to 6bd56ec Compare November 29, 2023 05:52

afuetterer and others added 4 commits November 29, 2023 06:53

build(deps): pin react-bootstrap

28d5045

build(deps-dev): bump the eslint group with 2 updates

7020856

Dependabot couldn't find the original pull request head commit, 9d6cdbe. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: bump eslint versions in pre-commit config

b9904a6

build(deps-dev): bump the webpack group with 4 updates

7a76824

afuetterer force-pushed the update-js-dependencies branch from 97092cc to c5dd7e7 Compare November 30, 2023 08:54

afuetterer mentioned this pull request Nov 30, 2023

build: update several dependencies #844

Merged

5 tasks

This comment was marked as resolved.

Sign in to view

afuetterer force-pushed the update-js-dependencies branch from c5dd7e7 to e1c4996 Compare November 30, 2023 15:01

This comment was marked as resolved.

Sign in to view

afuetterer added 2 commits November 30, 2023 21:30

test: take a screenshot of frontend for visual inspection

6b1076d

ci: ignore patch version updates in dependabot config

7d75993

afuetterer force-pushed the update-js-dependencies branch from e1c4996 to 7d75993 Compare November 30, 2023 20:30

MyPyDavid approved these changes Dec 1, 2023

View reviewed changes

afuetterer merged commit 3045403 into rdmorganiser:dependency-updates Dec 1, 2023
12 checks passed

afuetterer deleted the update-js-dependencies branch December 1, 2023 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: batch update javascript dependencies #839

build: batch update javascript dependencies #839

afuetterer commented Nov 23, 2023 •

edited

Loading

This comment was marked as resolved.

MyPyDavid commented Nov 24, 2023 •

edited

Loading

MyPyDavid commented Nov 24, 2023 •

edited

Loading

MyPyDavid commented Nov 24, 2023

afuetterer commented Nov 24, 2023

afuetterer commented Nov 24, 2023

MyPyDavid commented Nov 24, 2023

afuetterer commented Nov 24, 2023

jochenklar commented Nov 24, 2023

afuetterer commented Nov 24, 2023

jochenklar commented Nov 24, 2023

afuetterer commented Nov 24, 2023

MyPyDavid commented Nov 24, 2023 •

edited

Loading

This comment was marked as resolved.

afuetterer commented Nov 30, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

afuetterer commented Nov 30, 2023

afuetterer commented Nov 30, 2023

MyPyDavid left a comment

afuetterer commented Dec 1, 2023

build: batch update javascript dependencies #839

build: batch update javascript dependencies #839

Conversation

afuetterer commented Nov 23, 2023 • edited Loading

Description

Types of Changes

Checklist

Tasks

This comment was marked as resolved.

MyPyDavid commented Nov 24, 2023 • edited Loading

MyPyDavid commented Nov 24, 2023 • edited Loading

MyPyDavid commented Nov 24, 2023

afuetterer commented Nov 24, 2023

afuetterer commented Nov 24, 2023

MyPyDavid commented Nov 24, 2023

afuetterer commented Nov 24, 2023

jochenklar commented Nov 24, 2023

afuetterer commented Nov 24, 2023

jochenklar commented Nov 24, 2023

afuetterer commented Nov 24, 2023

MyPyDavid commented Nov 24, 2023 • edited Loading

This comment was marked as resolved.

afuetterer commented Nov 30, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

afuetterer commented Nov 30, 2023

afuetterer commented Nov 30, 2023

MyPyDavid left a comment

Choose a reason for hiding this comment

afuetterer commented Dec 1, 2023

afuetterer commented Nov 23, 2023 •

edited

Loading

MyPyDavid commented Nov 24, 2023 •

edited

Loading

MyPyDavid commented Nov 24, 2023 •

edited

Loading

MyPyDavid commented Nov 24, 2023 •

edited

Loading