-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on logger #1062
Remove dependency on logger #1062
Conversation
* To fix the Ruby 3.3.5 warnings: ruby-concurrency#1061 * concurrent-ruby only uses 7 constants from Logger, so just copy those over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks okay to me, but I'd personally try to remove logging as a concern of this library.
Probably (1) and (3) - basically remove it entirely. |
> NameError: > uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger See: ruby-concurrency/concurrent-ruby#1062
The release of this seems to have broken Rails 7.0 codebases with
I think ActiveSupport::LoggerThreadSafeLevel happened to be depending on Logger implicitly, so the fix is likely to just update Rails to require 'logger' there. I'll send a PR over there for the fix. Workaround locally is to add the require early. |
same problem with cocoapods |
## Ruby 3.4 is out ### 1. Add Bundled gems for Ruby 3.4 https://bugs.ruby-lang.org/issues/20187 It has already been backported to the 7-0-stable branch, but is not included in 7.0.8.7. - https://github.com/rails/rails/blob/7-0-stable/activesupport/activesupport.gemspec#L41-L43 - https://github.com/rails/rails/blob/v7.0.8.7/activesupport/activesupport.gemspec ### 2. concurrent-ruby 1.3.5 don't work on Rails 7.0 > NameError: > uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger See: ruby-concurrency/concurrent-ruby#1062
## Ruby 3.4 is out ### 1. concurrent-ruby 1.3.5 don't work on Rails 7.0 > NameError: > uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger See: ruby-concurrency/concurrent-ruby#1062
## Ruby 3.4 is out ### 1. concurrent-ruby 1.3.5 don't work on Rails 7.0 > NameError: > uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger See: ruby-concurrency/concurrent-ruby#1062
## Ruby 3.4 is out ### 1. concurrent-ruby 1.3.5 don't work on Rails 7.0 > NameError: > uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger See: ruby-concurrency/concurrent-ruby#1062
This should be fully compatible and address the warnings.
Only if one uses the long-deprecated
Concurrent.create_stdlib_logger
they might need to addlogger
to their Gemfile.