Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic unicode support for IDF4 #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pachi
Copy link

@pachi pachi commented Sep 14, 2015

This branch adds basic unicode support to IDF files. At this moment this means supporting field data and writing support just for IDF4 models.

@pachi
Copy link
Author

pachi commented Sep 14, 2015

IMHO, reviewing all the string uses in the code would lead to clean unicode support and would make migrating to an hybrid python2/3 codebase easier. I'll try to contribute further fixes.

@santoshphilip
Copy link
Owner

This issue of unicode affects many parts of the code.
for instance

idf.idobjects["ZONE"].Name 

can be made unicode and can have unicode operations (as your code shows)

Now:

idf.idfobjects["BuildingSurface:Detailed"].Zone_Name

also has to he unicode and any operations on it has to be unicode :-(

I am going to hold off on your code update until I have clarity on how to attack this problem. My thinking is to seed the unit tests with unicode inputs and see how the tests fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants