Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Transmuxer): Fix transmuxer with overflow data (video nalus and aac samples) between PES #7813

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 30, 2024

Fixes #7812
Fixes #7471

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: transmuxer The issue involves our built-in transmuxer labels Dec 30, 2024
@avelad avelad added this to the v4.13 milestone Dec 30, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Dec 30, 2024

Incremental code coverage: 88.74%

@avelad avelad force-pushed the aac-overflow-ts branch 2 times, most recently from e191b06 to bb6f145 Compare December 31, 2024 08:55
@avelad avelad changed the title fix(Transmuxer): Fix transmuxer when AAC in TS have overflow samples between PES fix(Transmuxer): Fix transmuxer when AAC in TS have overflow aac samples Dec 31, 2024
@avelad avelad changed the title fix(Transmuxer): Fix transmuxer when AAC in TS have overflow aac samples fix(Transmuxer): Fix transmuxer with overflow data (video nalus and aac samples) between PES Dec 31, 2024
@avelad avelad merged commit 77c4251 into shaka-project:main Jan 2, 2025
31 of 32 checks passed
@avelad avelad deleted the aac-overflow-ts branch January 2, 2025 07:55
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: transmuxer The issue involves our built-in transmuxer priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
3 participants