Add new software bfd state db table in schema #957
Conversation
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Commenter does not have sufficient privileges for PR 957 in repo sonic-net/sonic-swss-common |
|
Hi @liuh-80, can you please re-run the automation and merge when successful? Looks like I don't have permission. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kperumalbfn can the azure pipeline be re-run? It looks like it timed out |
common/schema.h
Outdated
| @@ -557,6 +557,7 @@ namespace swss { | |||
| #define STATE_TUNNEL_DECAP_TERM_TABLE_NAME "TUNNEL_DECAP_TERM_TABLE" | |||
|
|
|||
| #define STATE_BFD_SESSION_TABLE_NAME "BFD_SESSION_TABLE" | |||
| #define STATE_BFD_SOFTWARE_SESSION_TABLE_NAME "SOFTWARE_BFD_SESSION_TABLE" | |||
There was a problem hiding this comment.
To be consistent with naming, can you rename to BFD_SOFTWARE_SESSION_TABLE
There was a problem hiding this comment.
In the HLD it's named as "SOFTWARE_BFD_SESSION_TABLE": https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/BFD/SmartSwitchDpuLivenessUsingBfd.md#23-bfd-active-passive-mode should it be updated everywhere or should the variable be changed to STATE_SOFTWARE_BFD_SESSION_TABLE_NAME ?
There was a problem hiding this comment.
@dypet we could update the HLD as well to keep consistent with other TABLES.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dypet
dismissed stale reviews from liuh-80, FengPan-Frank, and kperumalbfn
via
7f283d9
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Not sure why Azure.sonic-swss-common failed, can it be re-run @prsunny ? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kperumalbfn it looks like the azure pipeline is stalled, can it be re-started? |
According this HDL, add a new definition for software BFD table in state DB in schema header file: https://github.com/kperumalbfn/SONiC/blob/kperumal/bfd/doc/smart-switch/BFD/SmartSwitchDpuLivenessUsingBfd.md