Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new software bfd state db table in schema #957

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Add new software bfd state db table in schema #957

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b4c780
Add new software bfd state db table in schema
abdbaig Dec 1, 2024
2ab6f2d
Merge branch 'master' into soft_bfd
liuh-80 Dec 3, 2024
952a82f
Merge branch 'master' into soft_bfd
abdbaig Dec 4, 2024
daede57
Merge branch 'master' into soft_bfd
liuh-80 Dec 9, 2024
2f55838
Merge branch 'master' into soft_bfd
dypet Jan 2, 2025
75a8c73
Merge branch 'master' into soft_bfd
kperumalbfn Jan 9, 2025
7f283d9
Update table name.
dypet Jan 14, 2025
333f040
Merge branch 'master' into soft_bfd
dypet Jan 15, 2025
a94c152
Merge branch 'master' into soft_bfd
dypet Jan 16, 2025
d0d30d9
Trigger pipeline.
dypet Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common/schema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@ namespace swss {
#define STATE_TUNNEL_DECAP_TERM_TABLE_NAME "TUNNEL_DECAP_TERM_TABLE"

#define STATE_BFD_SESSION_TABLE_NAME "BFD_SESSION_TABLE"
#define STATE_BFD_SOFTWARE_SESSION_TABLE_NAME "SOFTWARE_BFD_SESSION_TABLE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with naming, can you rename to BFD_SOFTWARE_SESSION_TABLE

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the HLD it's named as "SOFTWARE_BFD_SESSION_TABLE": https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/BFD/SmartSwitchDpuLivenessUsingBfd.md#23-bfd-active-passive-mode should it be updated everywhere or should the variable be changed to STATE_SOFTWARE_BFD_SESSION_TABLE_NAME ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dypet we could update the HLD as well to keep consistent with other TABLES.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

#define STATE_ROUTE_TABLE_NAME "ROUTE_TABLE"
#define STATE_VNET_RT_TUNNEL_TABLE_NAME "VNET_ROUTE_TUNNEL_TABLE"
#define STATE_ADVERTISE_NETWORK_TABLE_NAME "ADVERTISE_NETWORK_TABLE"
Expand Down
Loading