Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refactor ts-scripts sync #3825

Closed
busma13 opened this issue Nov 13, 2024 · 2 comments · Fixed by #3831
Closed

Review and refactor ts-scripts sync #3825

busma13 opened this issue Nov 13, 2024 · 2 comments · Fixed by #3831
Assignees

Comments

@busma13
Copy link
Contributor

busma13 commented Nov 13, 2024

While working on #3823 I ran into an issue where sync assumes that we will be using a minor range(^), so yarn sync failed when it changed all the ~ back to ^.

We at minimum need to convert sync to expect a patch range, but we have run into other problems with sync doing things we did not expect recently.
If we can review the code and determine what functionality is still needed, and it doesn't look to difficult to separate it out and discard the rest, that would be best.

@busma13
Copy link
Contributor Author

busma13 commented Nov 13, 2024

After taking a look, we are going to remove generateTSConfig and executeHook from the sync command. The tsconfig is easy to update and executeHook is not used anywhere.

@godber
Copy link
Member

godber commented Nov 22, 2024

Closed by #3831

@godber godber closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants