Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] syncAll refactor and patch dependency range fix #3831

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Nov 14, 2024

This PR makes the following changes:

  • Update all places in ts-scripts where ^ was the expected default range for a package version and instead use ~. This will match the patch level specificity we want in all our packages now.
  • remove executeHook() function: this was a feature that let you run a script in the middle of the sync or bump commands. It had not been used for a long time.
  • remove generateTSConfig() function: it was decided it would be best to handle tsconfig changes manually.
  • Update all dependency versions to use patch level specificity(~) instead of minor level(^)
  • Remove unused dependencies:
    • terafoundation:
      • @types/mongoose
      • @types/redis
    • teraslice-cli:
      • events
      • yo
      • @types/easy-table

closes: #3825, #3823

see PR #3824

@busma13 busma13 marked this pull request as ready for review November 15, 2024 15:53
@busma13 busma13 changed the title [scripts] syncAll refactor and patch dependency range fix [all] syncAll refactor and patch dependency range fix Nov 15, 2024
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit 0d16a36 into master Nov 19, 2024
49 checks passed
@jsnoble jsnoble deleted the ts-scripts-sync-fix branch November 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and refactor ts-scripts sync
2 participants