-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix linting, formatting, and git hooks configs #291
Conversation
Ditto. I'll create an issue for potentially ditching husky (and I'll let it simmer a few days to see if anyone comes out of the woodwork to oppose the motion. :-) |
Co-authored-by: Michael Cousins <[email protected]>
Co-authored-by: Michael Cousins <[email protected]>
@yanick I've noticed PRs landing with merge commits, would you mind if we switched to squash merges? I find they're much easier for contributors (no need to keep an individual PR's history clean) and they tend to be more reliable with automatic versioning tools like semantic-release If not, let me know and I can squash up the history here myself |
In theory I prefer merge commits, but in reality I have to admit that the power of having a branch history is rarely used to have commits of the form "I did this..." "... and then that..." "and finally that" and much more "I did this..." "...and then prettier complained..." "... and I made a typo..." "... does it work now?", so yeah practically it's not that much of a good thing. :-) So, sure, I'll go and switch the setting to squashing and let's try it. |
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
This PR fixes some code quality configs and hookups that we making it difficult to contribute effectively to this project.
Part of a two PR change set:
Change log
eslint-plugin-svelte
,@typescript-eslint/eslint-plugin
,eslint-plugin-prettier
into the ESLint config to:.svelte
files.d.ts
fileslint-staged
config now that Husky is actually working(On a personal note, I'm not a huge fan of pre-commit hooks anymore. I find they interfere with people's personal work styles, and they're pretty unnecessary in a PR-squashing-based workflow. I'd be down to ditch the pre-commit stuff from the repo entirely)