Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote Prettier warnings to errors in CI and format all files #292

Closed
wants to merge 1 commit into from
Closed

chore: promote Prettier warnings to errors in CI and format all files #292

wants to merge 1 commit into from

Conversation

mcous
Copy link
Collaborator

@mcous mcous commented Jan 25, 2024

Overview

This PR fixes some code quality configs and hookups that we making it difficult to contribute effectively to this project.

Part of a two PR change set:

  1. chore: fix linting, formatting, and git hooks configs #291
  2. chore: promote Prettier warnings to errors in CI and format all files #292 <-- you are here

Change log

  • Remove temporary || true from lint script
  • Run npm run format on the code base
  • Re-run contributor generation for README

@mcous mcous marked this pull request as ready for review January 26, 2024 22:50
@mcous
Copy link
Collaborator Author

mcous commented Jan 29, 2024

See #301 (comment)

@mcous mcous closed this Jan 29, 2024
@mcous mcous deleted the improve-formatting branch January 29, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant