Skip to content

Commit

Permalink
Merge pull request #593 from jacobweinstock/osie-baseurl-bugfix
Browse files Browse the repository at this point in the history
Fix how we check for OSIE.BaseURL:

## Description

<!--- Please describe what this PR is going to change -->
The object that gets returned from Kubernetes seems to always come back non-nil. So we need to also check if the string is empty.

## Why is this needed

<!--- Link to issue you have raised -->

Fixes: #

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->


## How are existing users impacted? What migration steps/scripts do we need?

<!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
<!--- Requires a DB migration script, etc. -->


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
  • Loading branch information
jacobweinstock authored Jan 30, 2025
2 parents afd6b7a + ad251cd commit c0443b8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/ipxe/script/ipxe.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func (h *Handler) defaultScript(span trace.Span, hw data) (string, error) {
Retries: h.IPXEScriptRetries,
RetryDelay: h.IPXEScriptRetryDelay,
}
if hw.OSIE.BaseURL != nil {
if hw.OSIE.BaseURL != nil && hw.OSIE.BaseURL.String() != "" {
auto.DownloadURL = hw.OSIE.BaseURL.String()
}
if hw.OSIE.Kernel != "" {
Expand Down

0 comments on commit c0443b8

Please sign in to comment.