Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explainer for Render Blocking Status #330

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

abinpaul1
Copy link
Contributor

No description provided.

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w3cbot
Copy link

w3cbot commented Jul 5, 2022

yoavweiss marked as non substantive for IPR from ash-nazg.

@w3cbot
Copy link

w3cbot commented Jul 5, 2022

yoavweiss marked as substantive for IPR from ash-nazg.

@yoavweiss
Copy link
Contributor

@caribouW3 - Abin is working on Render Blocking signal in Resource Timing. Can we add him as an Invited Expert?

@caribouW3
Copy link
Member

@caribouW3 - Abin is working on Render Blocking signal in Resource Timing. Can we add him as an Invited Expert?

No objection from my perspective. (https://www.w3.org/groups/wg/webperf/instructions)

Explainers/Render_Blocking_Status.md Outdated Show resolved Hide resolved

`non-blocking` - Non blocking resource

We primarily reuse the value of the [render blocking](https://fetch.spec.whatwg.org/#request-render-blocking) boolean associated with fetch [request](https://fetch.spec.whatwg.org/#concept-request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We primarily reuse the value of the [render blocking](https://fetch.spec.whatwg.org/#request-render-blocking) boolean associated with fetch [request](https://fetch.spec.whatwg.org/#concept-request)
We primarily reuse the value of the [render-blocking](https://fetch.spec.whatwg.org/#request-render-blocking) boolean associated with fetch [request](https://fetch.spec.whatwg.org/#concept-request)

Also the HTML spec uses "render-blocking" rather than "render blocking", even when not explicitly referring to the render-blocking boolean, which seems more correct to me. Should we use that format throughout this doc (which would also avoid errors like this when actually refer to the boolean)?

And, if so, possibly rename the file too to Render-blocking_Status.md - or would that mix of dashes and underscores just be confusing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've made the changes everywhere in the doc. It does make sense to allign with the existing terminology in the spec.

I also think now I should update it in the spec PR (#327) as well, so that that is also in line with the existing terminology. WDYT?

And, if so, possibly rename the file too to Render-blocking_Status.md - or would that mix of dashes and underscores just be confusing?

This explainer in my repo was linked to various places, so if I change the name those links might become inaccessible. I'll rename it in a follow up PR after this lands?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. Updating the spec PR similarly seems sensible to me.

@yoavweiss yoavweiss merged commit 80359de into w3c:gh-pages Sep 26, 2022
@abinpaul1 abinpaul1 deleted the explainer-render-blocking-status branch September 26, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants