Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explainer for Render Blocking Status #330
Explainer for Render Blocking Status #330
Changes from 1 commit
4064953
4e60e98
5df99a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the HTML spec uses "render-blocking" rather than "render blocking", even when not explicitly referring to the
render-blocking
boolean, which seems more correct to me. Should we use that format throughout this doc (which would also avoid errors like this when actually refer to the boolean)?And, if so, possibly rename the file too to
Render-blocking_Status.md
- or would that mix of dashes and underscores just be confusing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've made the changes everywhere in the doc. It does make sense to allign with the existing terminology in the spec.
I also think now I should update it in the spec PR (#327) as well, so that that is also in line with the existing terminology. WDYT?
This explainer in my repo was linked to various places, so if I change the name those links might become inaccessible. I'll rename it in a follow up PR after this lands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that. Updating the spec PR similarly seems sensible to me.