All search #11534
Merged
All search #11534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpmccormick
commented
Jan 27, 2025
| <p className={font('intr', 5)}> | ||
| {contentQueryFailed ? ( | ||
| <> | ||
| There was a problem fetching some search results. Please try |
There was a problem hiding this comment.
This would need an editor to write it for real
There was a problem hiding this comment.
Fairs, could create a new ticket for error messages or add it to the no results scenarios as those will be worked on next sprint?
There was a problem hiding this comment.
rcantin-w
reviewed
Jan 28, 2025
rcantin-w
reviewed
Jan 28, 2025
content/webapp/components/ContentSearchResult/ContentSearchResult.tsx
Outdated
Show resolved
Hide resolved
rcantin-w
reviewed
Jan 28, 2025
rcantin-w
reviewed
Jan 28, 2025
There was a problem hiding this comment.
content/webapp/components/ContentSearchResult/ContentSearchResult.tsx
I thought we were moving towards the content/webapp/components/ContentSearchResult/index.tsx model.
It's fine if not, but just a naming thing that if we don't want we should change the others that have it?
Although I still think we could move the other "SearchResults" component under the umbrella of one folder and then index becomes confusing!
rcantin-w
reviewed
Jan 28, 2025
rcantin-w
reviewed
Jan 28, 2025
|
The links for Exhibition Text don't lead to the captions-and-transcript page (like Hard graft's http://localhost:3000/search?query=hard+graft) |
|
It's reaaaaally cool to see it come to life 🙌 loved switching to this branch and rendering it. |
Nice spot thanks! |
rcantin-w
reviewed
Jan 29, 2025
| if (type === 'exhibition-texts') { | ||
| return `/guides/exhibitions/${uid}/captions-and-transcripts`; | ||
| } | ||
|
|
||
| if (type === 'visual-stories') { |
There was a problem hiding this comment.
We're not returning the "correct" URL here, since we don't have 'data', it goes to the fallback URL - do we mind? (maybe one for Lauren).
http://localhost:3000/visual-stories/hard-graft
should be
http://localhost:3000/exhibitions/hard-graft-work-health-and-rights/visual-stories
rcantin-w
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Audio highlight tour is there at least 3x; even though it says 5 results, this makes it look like there are more
http://localhost:3000/search?query=hard+graft+highlight
Hermmm I can't replicate anymore.... Weird? Hot reload? Will keep an eye out 🤔 UPDATE: I was able to replicate! It's on query change. So try "hard graft" -> search -> "hard graft highlight" -> search; there are more results displaying than should. |
|
Not for this PR and probs needs Lauren/design but some pages don't have descriptions and it looks off. We could run a script seeing which ones they are and if Editorial could just address those, maybe make it a Prismic linting rule? EDIT: I'll talk about this with Lauren UPDATE: I've sent the list to Editorial to amend 
|
Nice catch! I was using the |
|
Size Change: +1.8 kB (+0.18%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
davidpmccormick
force-pushed
the
all-search
branch
from
88d52fd to
369354c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11460
What does this change?
Adds a
ContentSearchResultcomponent and uses it behind theallSearchtoggle on the new search pageHow to test
Turn on the toggle, search for something, check the linkResolver takes you to where it should for each of the possible content types.
I used the existing Pagination component (if/when we update to match the designs, I think that could be a larger piece of work to make that change everywhere we do pagination).
Catalogue results are being dealt with separately. I also backed out of tackling the styling of the search box and adding then number of hits per section as part of this PR. It would require several more requests and maybe needs more discussion before it gets built
How can we measure success?
We can serve site-search information to users rather than them having to Ask Jeeves
Have we considered potential risks?
Things link to the wrong place/display incorrectly. It's behind a toggle so this shouldn't be a problem for as long as that's the case if so