feat(fast-usdc): skipAdvance when preconditions fail #11005
Conversation
samsiegart
force-pushed
the
srs-skip-advance
branch
from
430a488 to
1a632b7
Compare
Deploying agoric-sdk with
|
| Latest commit: |
cfe0954
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6a3265ba.agoric-sdk.pages.dev |
| Branch Preview URL: | https://srs-skip-advance.agoric-sdk.pages.dev |
| @@ -217,7 +217,7 @@ export const prepareAdvancerKit = ( | |||
| }); | |||
| } catch (error) { | |||
| log('Advancer error:', error); | |||
| statusManager.observe(evidence); | |||
| statusManager.skipAdvance(evidence, ['PRECONDITIONS_FAILED']); | |||
There was a problem hiding this comment.
This looks good. As discussed offline let's try this approach, like smart wallet:
| statusManager.skipAdvance(evidence, ['PRECONDITIONS_FAILED']); | |
| statusManager.skipAdvance(evidence, [error.message]); |
samsiegart
force-pushed
the
srs-skip-advance
branch
from
8d1e131 to
48ef22e
Compare
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
samsiegart
force-pushed
the
srs-skip-advance
branch
from
48ef22e to
cfe0954
Compare
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
closes #10994
Description
If any of the preconditions throw for making the advance, set the state to
ADVANCE_SKIPPEDrather thanOBSERVED. This makes it more obvious that the contract has actively chosen to not advance, rather than getting stuck onOBSERVEDfor some reason.Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
I don't think we have any docs that go this granular on the flow.
Testing Considerations
Updated tests
Upgrade Considerations
N/A